From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25227C432C3 for ; Sat, 16 Nov 2019 16:07:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E54292089D for ; Sat, 16 Nov 2019 16:07:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573920434; bh=H0+p4fK298kw1jSTheIrFbd+g0vAAzU0oZwSoqofGG0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Mkk9XoyBfdJsjK9we7O+zi1VDfcsq3kluHD5+aEPIkocsReIAp9dnOP+XbjPpwY5C rIfSSFT9J6CZsPcoa4t/Tf/jU424NJwwSt/aeDTGZc7SZqyqrHY/nDvIh/uRekvr4i nuWCaMDXsBK6Zo8azXjtT0y20WIV381/iRzsjkxE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731775AbfKPQHN (ORCPT ); Sat, 16 Nov 2019 11:07:13 -0500 Received: from mail.kernel.org ([198.145.29.99]:58770 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730564AbfKPPug (ORCPT ); Sat, 16 Nov 2019 10:50:36 -0500 Received: from sasha-vm.mshome.net (unknown [50.234.116.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 450F4214E0; Sat, 16 Nov 2019 15:50:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573919435; bh=H0+p4fK298kw1jSTheIrFbd+g0vAAzU0oZwSoqofGG0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BJjnK1vn0Bkz+efrUPs2DDHeTS/fXYvVYRPJK7e3qos2qWPpBEa6uXA7Gmk9grWN9 VTblhEAR0u6OijSSZlzAdL58x5Lv4FKC7cu/Bs+1ycgaY0EaodTgxt1HPKRYNP27ho 71eeonpXRY11xJlECm0W09+T3bpF1PxJsjy1Ns+Y= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Tycho Andersen , David Teigland , Sasha Levin , cluster-devel@redhat.com Subject: [PATCH AUTOSEL 4.14 134/150] dlm: fix invalid free Date: Sat, 16 Nov 2019 10:47:12 -0500 Message-Id: <20191116154729.9573-134-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191116154729.9573-1-sashal@kernel.org> References: <20191116154729.9573-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tycho Andersen [ Upstream commit d968b4e240cfe39d39d80483bac8bca8716fd93c ] dlm_config_nodes() does not allocate nodes on failure, so we should not free() nodes when it fails. Signed-off-by: Tycho Andersen Signed-off-by: David Teigland Signed-off-by: Sasha Levin --- fs/dlm/member.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/dlm/member.c b/fs/dlm/member.c index 3fda3832cf6a6..cad6d85911a80 100644 --- a/fs/dlm/member.c +++ b/fs/dlm/member.c @@ -680,7 +680,7 @@ int dlm_ls_start(struct dlm_ls *ls) error = dlm_config_nodes(ls->ls_name, &nodes, &count); if (error < 0) - goto fail; + goto fail_rv; spin_lock(&ls->ls_recover_lock); @@ -712,8 +712,9 @@ int dlm_ls_start(struct dlm_ls *ls) return 0; fail: - kfree(rv); kfree(nodes); + fail_rv: + kfree(rv); return error; } -- 2.20.1