From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DD05C432C3 for ; Sat, 16 Nov 2019 16:00:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F217C20815 for ; Sat, 16 Nov 2019 16:00:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573920017; bh=6je34wnW9tnycplKf4r69UXfLC8g/37BuLjL0ZEKLJU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=XAcCn9RpCqFP95R0jM/wkaTzd+fKB/o3SfrOgwOLeVvOKDZx/M1qvwtdFvQIuxjes J/xphx+M3DESAkBdzF4aXIkPmMccCAGgJMsG4JNsk8s+Zp9TIjT5hYMsD5f5iLWbWU tx6anKPU7pirN7JB7iAklfFtjZrDCjA4AZO0KmTU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731035AbfKPQAQ (ORCPT ); Sat, 16 Nov 2019 11:00:16 -0500 Received: from mail.kernel.org ([198.145.29.99]:34886 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729935AbfKPPxl (ORCPT ); Sat, 16 Nov 2019 10:53:41 -0500 Received: from sasha-vm.mshome.net (unknown [50.234.116.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9D51721479; Sat, 16 Nov 2019 15:53:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573919620; bh=6je34wnW9tnycplKf4r69UXfLC8g/37BuLjL0ZEKLJU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NHCNs5ud236ajRZHyYI9T4HAYc6ta3N/GZ0iNM+xYtb3ZTd4lW28hsvnEzxI4hBrn 0bCU3ecsBce9PD1lhUeaTlz7u4rgqq7LSwhPMwgNG/9qAhjS0nyyiA9xEJsn08OO2T gFOevMnHyl9+maF4p1aGQ6B8Fv0+V9dzjqqFseC0= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Sergey Senozhatsky , Sergey Senozhatsky , Petr Mladek , Sasha Levin Subject: [PATCH AUTOSEL 4.4 02/77] printk: fix integer overflow in setup_log_buf() Date: Sat, 16 Nov 2019 10:52:24 -0500 Message-Id: <20191116155339.11909-2-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191116155339.11909-1-sashal@kernel.org> References: <20191116155339.11909-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sergey Senozhatsky [ Upstream commit d2130e82e9454304e9b91ba9da551b5989af8c27 ] The way we calculate logbuf free space percentage overflows signed integer: int free; free = __LOG_BUF_LEN - log_next_idx; pr_info("early log buf free: %u(%u%%)\n", free, (free * 100) / __LOG_BUF_LEN); We support LOG_BUF_LEN of up to 1<<25 bytes. Since setup_log_buf() is called during early init, logbuf is mostly empty, so __LOG_BUF_LEN - log_next_idx is close to 1<<25. Thus when we multiply it by 100, we overflow signed integer value range: 100 is 2^6 + 2^5 + 2^2. Example, booting with LOG_BUF_LEN 1<<25 and log_buf_len=2G boot param: [ 0.075317] log_buf_len: -2147483648 bytes [ 0.075319] early log buf free: 33549896(-28%) Make "free" unsigned integer and use appropriate printk() specifier. Link: http://lkml.kernel.org/r/20181010113308.9337-1-sergey.senozhatsky@gmail.com To: Steven Rostedt Cc: linux-kernel@vger.kernel.org Cc: Sergey Senozhatsky Signed-off-by: Sergey Senozhatsky Signed-off-by: Petr Mladek Signed-off-by: Sasha Levin --- kernel/printk/printk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index 5a1b2a914b4e5..2938e5c8561ad 100644 --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c @@ -931,7 +931,7 @@ void __init setup_log_buf(int early) { unsigned long flags; char *new_log_buf; - int free; + unsigned int free; if (log_buf != __log_buf) return; -- 2.20.1