* [PATCH] drm/msm/dpu: ignore NULL clocks
@ 2019-11-14 18:51 Rob Clark
2019-11-14 23:26 ` Linus Walleij
2019-11-17 1:29 ` Stephen Boyd
0 siblings, 2 replies; 3+ messages in thread
From: Rob Clark @ 2019-11-14 18:51 UTC (permalink / raw)
To: dri-devel
Cc: Stephen Boyd, Rob Clark, Matthias Kaehlcke, Rob Clark, Sean Paul,
David Airlie, Daniel Vetter, Thomas Gleixner, Jordan Crouse,
Alexios Zavras, Greg Kroah-Hartman, Linus Walleij, Mamta Shukla,
open list:DRM DRIVER FOR MSM ADRENO GPU,
open list:DRM DRIVER FOR MSM ADRENO GPU, open list
From: Rob Clark <robdclark@chromium.org>
This isn't an error. Also the clk APIs handle the NULL case, so we can
just delete the check.
Signed-off-by: Rob Clark <robdclark@chromium.org>
Tested-by: Matthias Kaehlcke <mka@chromium.org>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_io_util.c | 26 ++++++---------------
1 file changed, 7 insertions(+), 19 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_io_util.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_io_util.c
index 27fbeb504362..ec1437b0ef75 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_io_util.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_io_util.c
@@ -93,19 +93,12 @@ int msm_dss_enable_clk(struct dss_clk *clk_arry, int num_clk, int enable)
DEV_DBG("%pS->%s: enable '%s'\n",
__builtin_return_address(0), __func__,
clk_arry[i].clk_name);
- if (clk_arry[i].clk) {
- rc = clk_prepare_enable(clk_arry[i].clk);
- if (rc)
- DEV_ERR("%pS->%s: %s en fail. rc=%d\n",
- __builtin_return_address(0),
- __func__,
- clk_arry[i].clk_name, rc);
- } else {
- DEV_ERR("%pS->%s: '%s' is not available\n",
- __builtin_return_address(0), __func__,
- clk_arry[i].clk_name);
- rc = -EPERM;
- }
+ rc = clk_prepare_enable(clk_arry[i].clk);
+ if (rc)
+ DEV_ERR("%pS->%s: %s en fail. rc=%d\n",
+ __builtin_return_address(0),
+ __func__,
+ clk_arry[i].clk_name, rc);
if (rc && i) {
msm_dss_enable_clk(&clk_arry[i - 1],
@@ -119,12 +112,7 @@ int msm_dss_enable_clk(struct dss_clk *clk_arry, int num_clk, int enable)
__builtin_return_address(0), __func__,
clk_arry[i].clk_name);
- if (clk_arry[i].clk)
- clk_disable_unprepare(clk_arry[i].clk);
- else
- DEV_ERR("%pS->%s: '%s' is not available\n",
- __builtin_return_address(0), __func__,
- clk_arry[i].clk_name);
+ clk_disable_unprepare(clk_arry[i].clk);
}
}
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/msm/dpu: ignore NULL clocks
2019-11-14 18:51 [PATCH] drm/msm/dpu: ignore NULL clocks Rob Clark
@ 2019-11-14 23:26 ` Linus Walleij
2019-11-17 1:29 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2019-11-14 23:26 UTC (permalink / raw)
To: Rob Clark
Cc: open list:DRM PANEL DRIVERS, Stephen Boyd, Rob Clark,
Matthias Kaehlcke, Sean Paul, David Airlie, Daniel Vetter,
Thomas Gleixner, Jordan Crouse, Alexios Zavras,
Greg Kroah-Hartman, Mamta Shukla,
open list:DRM DRIVER FOR MSM ADRENO GPU,
open list:DRM DRIVER FOR MSM ADRENO GPU, open list
On Thu, Nov 14, 2019 at 7:54 PM Rob Clark <robdclark@gmail.com> wrote:
> From: Rob Clark <robdclark@chromium.org>
>
> This isn't an error. Also the clk APIs handle the NULL case, so we can
> just delete the check.
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> Tested-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/msm/dpu: ignore NULL clocks
2019-11-14 18:51 [PATCH] drm/msm/dpu: ignore NULL clocks Rob Clark
2019-11-14 23:26 ` Linus Walleij
@ 2019-11-17 1:29 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2019-11-17 1:29 UTC (permalink / raw)
To: Rob Clark, dri-devel
Cc: Rob Clark, Matthias Kaehlcke, Rob Clark, Sean Paul, David Airlie,
Daniel Vetter, Thomas Gleixner, Jordan Crouse, Alexios Zavras,
Greg Kroah-Hartman, Linus Walleij, Mamta Shukla, linux-arm-msm,
freedreno, linux-kernel
Quoting Rob Clark (2019-11-14 10:51:50)
> From: Rob Clark <robdclark@chromium.org>
>
> This isn't an error. Also the clk APIs handle the NULL case, so we can
> just delete the check.
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> Tested-by: Matthias Kaehlcke <mka@chromium.org>
> ---
Acked-by: Stephen Boyd <sboyd@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-17 1:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-14 18:51 [PATCH] drm/msm/dpu: ignore NULL clocks Rob Clark
2019-11-14 23:26 ` Linus Walleij
2019-11-17 1:29 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).