From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EE73C43215 for ; Sun, 17 Nov 2019 04:12:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5383D20850 for ; Sun, 17 Nov 2019 04:12:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726174AbfKQEKV (ORCPT ); Sat, 16 Nov 2019 23:10:21 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:49711 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725839AbfKQEKU (ORCPT ); Sat, 16 Nov 2019 23:10:20 -0500 Received: from callcc.thunk.org (pool-72-93-95-157.bstnma.fios.verizon.net [72.93.95.157]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id xAH49jHK017868 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 16 Nov 2019 23:09:47 -0500 Received: by callcc.thunk.org (Postfix, from userid 15806) id 7153F4202FD; Sat, 16 Nov 2019 23:09:45 -0500 (EST) Date: Sat, 16 Nov 2019 23:09:45 -0500 From: "Theodore Y. Ts'o" To: Herbert Xu Cc: "Maciej S. Szmigiero" , Stephen Boyd , Arnd Bergmann , Greg Kroah-Hartman , Sebastian Andrzej Siewior , Keerthy , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] random: Don't freeze in add_hwgenerator_randomness() if stopping kthread Message-ID: <20191117040945.GB31360@mit.edu> References: <20191110135543.3476097-1-mail@maciej.szmigiero.name> <5dcee409.1c69fb81.f5027.48ad@mx.google.com> <415922ac-3c87-081c-6fdf-73fc97d0f397@maciej.szmigiero.name> <20191117005641.qgremf2lrj46qy4p@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191117005641.qgremf2lrj46qy4p@gondor.apana.org.au> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 17, 2019 at 08:56:41AM +0800, Herbert Xu wrote: > On Sun, Nov 17, 2019 at 12:01:20AM +0100, Maciej S. Szmigiero wrote: > > > > If a reader (user space) task is frozen then it is no longer waiting > > on this waitqueue - at least if I understand correctly how the freezer > > works for user space tasks, that is by interrupting waits via a fake > > signal. > > At this point I'm just going to revert the whole thing and we can > sort it out in the next development cycle. Thanks, I hadn't planned on taking any /dev/random changes this cycle because it had gotten too late and the ext4 tree had gotten unusually busy. - Ted