* [PATCH] ASoC: wm5100: add missed pm_runtime_disable
@ 2019-11-18 7:37 Chuhong Yuan
2019-11-18 11:47 ` Charles Keepax
0 siblings, 1 reply; 2+ messages in thread
From: Chuhong Yuan @ 2019-11-18 7:37 UTC (permalink / raw)
Cc: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
patches, alsa-devel, linux-kernel, Chuhong Yuan
The driver forgets to call pm_runtime_disable in remove and
probe failure.
Add the calls to fix it.
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
sound/soc/codecs/wm5100.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/codecs/wm5100.c b/sound/soc/codecs/wm5100.c
index 4af0e519e623..91cc63c5a51f 100644
--- a/sound/soc/codecs/wm5100.c
+++ b/sound/soc/codecs/wm5100.c
@@ -2617,6 +2617,7 @@ static int wm5100_i2c_probe(struct i2c_client *i2c,
return ret;
err_reset:
+ pm_runtime_disable(&i2c->dev);
if (i2c->irq)
free_irq(i2c->irq, wm5100);
wm5100_free_gpio(i2c);
@@ -2640,6 +2641,7 @@ static int wm5100_i2c_remove(struct i2c_client *i2c)
{
struct wm5100_priv *wm5100 = i2c_get_clientdata(i2c);
+ pm_runtime_disable(&i2c->dev);
if (i2c->irq)
free_irq(i2c->irq, wm5100);
wm5100_free_gpio(i2c);
--
2.24.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: wm5100: add missed pm_runtime_disable
2019-11-18 7:37 [PATCH] ASoC: wm5100: add missed pm_runtime_disable Chuhong Yuan
@ 2019-11-18 11:47 ` Charles Keepax
0 siblings, 0 replies; 2+ messages in thread
From: Charles Keepax @ 2019-11-18 11:47 UTC (permalink / raw)
To: Chuhong Yuan
Cc: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
patches, alsa-devel, linux-kernel
On Mon, Nov 18, 2019 at 03:37:07PM +0800, Chuhong Yuan wrote:
> The driver forgets to call pm_runtime_disable in remove and
> probe failure.
> Add the calls to fix it.
>
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
> ---
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-18 11:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-18 7:37 [PATCH] ASoC: wm5100: add missed pm_runtime_disable Chuhong Yuan
2019-11-18 11:47 ` Charles Keepax
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).