From: Luis Henriques <lhenriques@suse.com>
To: Jeff Layton <jlayton@kernel.org>, Sage Weil <sage@redhat.com>,
Ilya Dryomov <idryomov@gmail.com>, "Yan, Zheng" <zyan@redhat.com>,
Gregory Farnum <gfarnum@redhat.com>
Cc: ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
Luis Henriques <lhenriques@suse.com>
Subject: [RFC PATCH v3] ceph: add new obj copy OSD Op
Date: Mon, 18 Nov 2019 12:09:33 +0000 [thread overview]
Message-ID: <20191118120935.7013-1-lhenriques@suse.com> (raw)
Hi,
Before going ahead with a pull-request for ceph I would like to make sure
we're all on the same page regarding the final fix for this problem.
Thus, following this email, I'm sending 2 patches: one for ceph OSDs and
the another for the kernel client.
* osd: add new 'copy-from-notrunc' operation
This patch shall be applied to ceph master after reverting commit
ba152435fd85 ("osd: add flag to prevent truncate_seq copy in copy-from
operation"). It adds a new operation that will be exactly the same as
the original 'copy-from' operation, but with the extra 2 parameters
(truncate_{seq,size})
* ceph: switch copy_file_range to 'copy-from-notrunc' operation
This will make the kernel client use the new OSD op in
copy_file_range. One extra thing that could probably be added is
changing the mount options to NOCOPYFROM if the first call to
ceph_osdc_copy_from() fails.
Does this look good, or did I missed something from the previous
discussion?
(One advantage of this approach: the OSD patch can be easily backported!)
Cheers,
--
Luis
Luis Henriques (1):
osd: add new 'copy-from-notrunc' operation
src/include/rados.h | 1 +
src/osd/OSD.cc | 3 ++-
src/osd/PrimaryLogPG.cc | 24 +++++++++++++++++++-----
3 files changed, 22 insertions(+), 6 deletions(-)
ceph: switch copy_file_range to 'copy-from-notrunc' operation
fs/ceph/file.c | 3 ++-
include/linux/ceph/osd_client.h | 1 +
include/linux/ceph/rados.h | 1 +
net/ceph/osd_client.c | 18 ++++++++++++------
4 files changed, 16 insertions(+), 7 deletions(-)
next reply other threads:[~2019-11-18 12:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-18 12:09 Luis Henriques [this message]
2019-11-18 12:09 ` [RFC PATCH] osd: add new 'copy-from-notrunc' operation Luis Henriques
2019-11-18 12:09 ` [RFC PATCH] ceph: switch copy_file_range to " Luis Henriques
2019-11-18 13:12 ` [RFC PATCH v3] ceph: add new obj copy OSD Op Jeff Layton
2019-11-18 14:05 ` Luis Henriques
2019-11-20 9:55 ` Luis Henriques
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191118120935.7013-1-lhenriques@suse.com \
--to=lhenriques@suse.com \
--cc=ceph-devel@vger.kernel.org \
--cc=gfarnum@redhat.com \
--cc=idryomov@gmail.com \
--cc=jlayton@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sage@redhat.com \
--cc=zyan@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).