From: Green Wan <green.wan@sifive.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Green Wan <green.wan@sifive.com>,
Dan Williams <dan.j.williams@intel.com>,
Vinod Koul <vkoul@kernel.org>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] dmaengine: sf-pdma: move macro to header file
Date: Mon, 18 Nov 2019 22:35:53 +0800 [thread overview]
Message-ID: <20191118143554.16129-2-green.wan@sifive.com> (raw)
In-Reply-To: <20191118143554.16129-1-green.wan@sifive.com>
The place where the macro, SF_PDMA_REG_BASE(), is cause kernel-doc
using wrong function declaration. Move it to header file.
Signed-off-by: Green Wan <green.wan@sifive.com>
---
drivers/dma/sf-pdma/sf-pdma.c | 1 -
drivers/dma/sf-pdma/sf-pdma.h | 2 ++
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/dma/sf-pdma/sf-pdma.c b/drivers/dma/sf-pdma/sf-pdma.c
index e8b9770dcfba..465256fe8b1f 100644
--- a/drivers/dma/sf-pdma/sf-pdma.c
+++ b/drivers/dma/sf-pdma/sf-pdma.c
@@ -435,7 +435,6 @@ static int sf_pdma_irq_init(struct platform_device *pdev, struct sf_pdma *pdma)
*
* Return: none
*/
-#define SF_PDMA_REG_BASE(ch) (pdma->membase + (PDMA_CHAN_OFFSET * (ch)))
static void sf_pdma_setup_chans(struct sf_pdma *pdma)
{
int i;
diff --git a/drivers/dma/sf-pdma/sf-pdma.h b/drivers/dma/sf-pdma/sf-pdma.h
index aab65a0bdfcc..0c20167b097d 100644
--- a/drivers/dma/sf-pdma/sf-pdma.h
+++ b/drivers/dma/sf-pdma/sf-pdma.h
@@ -57,6 +57,8 @@
/* Error Recovery */
#define MAX_RETRY 1
+#define SF_PDMA_REG_BASE(ch) (pdma->membase + (PDMA_CHAN_OFFSET * (ch)))
+
struct pdma_regs {
/* read-write regs */
void __iomem *ctrl; /* 4 bytes */
--
2.17.1
next prev parent reply other threads:[~2019-11-18 14:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-18 14:35 [PATCH 1/2] dmaengine: sf-pdma: replace /** with /* for non-function comment Green Wan
2019-11-18 14:35 ` Green Wan [this message]
2019-11-22 5:45 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191118143554.16129-2-green.wan@sifive.com \
--to=green.wan@sifive.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).