From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74C85C43215 for ; Mon, 18 Nov 2019 14:36:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 57A7220722 for ; Mon, 18 Nov 2019 14:36:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727218AbfKROgj (ORCPT ); Mon, 18 Nov 2019 09:36:39 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:58190 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726654AbfKROgj (ORCPT ); Mon, 18 Nov 2019 09:36:39 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 5FDC71C17F8; Mon, 18 Nov 2019 15:36:37 +0100 (CET) Date: Mon, 18 Nov 2019 15:36:36 +0100 From: Pavel Machek To: kan.liang@linux.intel.com Cc: peterz@infradead.org, mingo@kernel.org, sashal@kernel.org, gregkh@linuxfoundation.org, pavel@denx.de, linux-kernel@vger.kernel.org, ak@linux.intel.com, alexander.shishkin@linux.intel.com, stable@vger.kernel.org Subject: Re: [PATCH] perf/x86/uncore: Remove unnecessary check for uncore_pmu Message-ID: <20191118143636.GD22736@duo.ucw.cz> References: <1573652102-131731-1-git-send-email-kan.liang@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="C+ts3FVlLX8+P6JN" Content-Disposition: inline In-Reply-To: <1573652102-131731-1-git-send-email-kan.liang@linux.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --C+ts3FVlLX8+P6JN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed 2019-11-13 05:35:02, kan.liang@linux.intel.com wrote: > From: Kan Liang >=20 > The uncore_pmu pointer in uncore_pmu_enable/disable() is from > container_of, which never be NULL. >=20 > Remove the unnecessary check for uncore_pmu. >=20 > Fixes: 75be6f703a14 ("perf/x86/uncore: Fix event group support") > Reported-by: Pavel Machek > Signed-off-by: Kan Liang > Cc: stable@vger.kernel.org Sorry, sent email too fast. I agree this is good fix for mainline, but as the code is a tiny bit ineffective but correct, I don't think we neccessarily need it in stable. Best regards, Pavel =09 --=20 DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany --C+ts3FVlLX8+P6JN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCXdKsdAAKCRAw5/Bqldv6 8mU3AJ9+JUK3UhvtIbQf/OVMZgQQFuaLqACeMvHDB/bq1neMOohhJzKkkzdH1gU= =T8Gj -----END PGP SIGNATURE----- --C+ts3FVlLX8+P6JN--