On Mon, Nov 18, 2019 at 08:53:57AM +0200, Matti Vaittinen wrote: > +#Supported default DVS states: > +#buck | run | idle | suspend | lpsr > +#---------------------------------------------------------------------------- > +#1, 2, 6, and 7 | supported | supported | supported (*) > +#---------------------------------------------------------------------------- > +#3, 4, and 5 | supported (**) > +#---------------------------------------------------------------------------- > +#(*) LPSR and SUSPEND states use same voltage but both states have own enable / > +# disable settings. Voltage 0 can be specified for a state to make regulator > +# disabled on that state. > +#(**) All states use same voltage but have own enable / disable settings. > +# Voltage 0 can be specified for a state to make regulator disabled on that > +# state. > + > + rohm,dvs-runlvl-ctrl: > + description: | > + buck control is done based on run-level. Regulator is not > + individually controllable. See ../mfd/rohm,bd71828-pmic.yaml for > + how to specify run-level control mechanism. Only bucks 1, 2, 6 > + and 7 support this. > + type: boolean I don't think I saw this having the effect on set_voltage() that I'd have expected in the driver? > + rohm,dvs-runlevel-microvolts: > + minimum: 0 > + maximum: 2000000 > + maxItems: 4 > + description: > + Array of voltages for run-levels. First value is for run-level 0, > + second for run-level 1 etc. Microvolts. What's the mapping from array indexes to the names used elsewhere to support runlevels?