* [PATCH v3 1/2] dt-bindings: arm: realtek: Document RTD1619 and Realtek Mjolnir EVB
@ 2019-11-12 15:45 James Tai
2019-11-13 21:01 ` Andreas Färber
2019-11-18 17:50 ` Rob Herring
0 siblings, 2 replies; 5+ messages in thread
From: James Tai @ 2019-11-12 15:45 UTC (permalink / raw)
To: Andreas Färber
Cc: Rob Herring, Mark Rutland, linux-arm-kernel, 'DTML',
linux-kernel, linux-realtek-soc
Define compatible strings for Realtek RTD1619 SoC and Realtek Mjolnir EVB.
Signed-off-by: James Tai <james.tai@realtek.com>
---
Documentation/devicetree/bindings/arm/realtek.yaml | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/realtek.yaml b/Documentation/devicetree/bindings/arm/realtek.yaml
index ab59de17152d..2444eff2c3d5 100644
--- a/Documentation/devicetree/bindings/arm/realtek.yaml
+++ b/Documentation/devicetree/bindings/arm/realtek.yaml
@@ -33,4 +33,10 @@ properties:
- enum:
- synology,ds418 # Synology DiskStation DS418
- const: realtek,rtd1296
+
+ # RTD1619 SoC based boards
+ - items:
+ - enum:
+ - realtek,mjolnir # Realtek Mjolnir EVB
+ - const: realtek,rtd1619
...
--
2.24.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: arm: realtek: Document RTD1619 and Realtek Mjolnir EVB
2019-11-12 15:45 [PATCH v3 1/2] dt-bindings: arm: realtek: Document RTD1619 and Realtek Mjolnir EVB James Tai
@ 2019-11-13 21:01 ` Andreas Färber
2019-11-15 14:42 ` James Tai
2019-11-18 17:50 ` Rob Herring
1 sibling, 1 reply; 5+ messages in thread
From: Andreas Färber @ 2019-11-13 21:01 UTC (permalink / raw)
To: James Tai
Cc: Rob Herring, Mark Rutland, linux-arm-kernel, 'DTML',
linux-kernel, linux-realtek-soc
Am 12.11.19 um 16:45 schrieb James Tai:
> Define compatible strings for Realtek RTD1619 SoC and Realtek Mjolnir EVB.
>
> Signed-off-by: James Tai <james.tai@realtek.com>
> ---
This is missing the requested change log here: What changed since v2?
If nothing changed, then you should've inserted my Reviewed-by from v2
before your Signed-off-by.
Regards,
Andreas
> Documentation/devicetree/bindings/arm/realtek.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/realtek.yaml b/Documentation/devicetree/bindings/arm/realtek.yaml
> index ab59de17152d..2444eff2c3d5 100644
> --- a/Documentation/devicetree/bindings/arm/realtek.yaml
> +++ b/Documentation/devicetree/bindings/arm/realtek.yaml
> @@ -33,4 +33,10 @@ properties:
> - enum:
> - synology,ds418 # Synology DiskStation DS418
> - const: realtek,rtd1296
> +
> + # RTD1619 SoC based boards
> + - items:
> + - enum:
> + - realtek,mjolnir # Realtek Mjolnir EVB
> + - const: realtek,rtd1619
> ...
>
--
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH v3 1/2] dt-bindings: arm: realtek: Document RTD1619 and Realtek Mjolnir EVB
2019-11-13 21:01 ` Andreas Färber
@ 2019-11-15 14:42 ` James Tai
0 siblings, 0 replies; 5+ messages in thread
From: James Tai @ 2019-11-15 14:42 UTC (permalink / raw)
To: Andreas Färber
Cc: Rob Herring, Mark Rutland, linux-arm-kernel, 'DTML',
linux-kernel, linux-realtek-soc
Hi Andreas,
> > Define compatible strings for Realtek RTD1619 SoC and Realtek Mjolnir EVB.
> >
> > Signed-off-by: James Tai <james.tai@realtek.com>
> > ---
>
> This is missing the requested change log here: What changed since v2?
>
> If nothing changed, then you should've inserted my Reviewed-by from v2
> before your Signed-off-by.
>
There is nothing changed. I'll correct the mistakes in next version.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: arm: realtek: Document RTD1619 and Realtek Mjolnir EVB
2019-11-12 15:45 [PATCH v3 1/2] dt-bindings: arm: realtek: Document RTD1619 and Realtek Mjolnir EVB James Tai
2019-11-13 21:01 ` Andreas Färber
@ 2019-11-18 17:50 ` Rob Herring
2019-12-28 14:20 ` Andreas Färber
1 sibling, 1 reply; 5+ messages in thread
From: Rob Herring @ 2019-11-18 17:50 UTC (permalink / raw)
To: James Tai
Cc: Andreas Färber, Mark Rutland, linux-arm-kernel,
'DTML',
linux-kernel, linux-realtek-soc
On Tue, 12 Nov 2019 15:45:13 +0000, James Tai wrote:
>
> Define compatible strings for Realtek RTD1619 SoC and Realtek Mjolnir EVB.
>
> Signed-off-by: James Tai <james.tai@realtek.com>
> ---
> Documentation/devicetree/bindings/arm/realtek.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: arm: realtek: Document RTD1619 and Realtek Mjolnir EVB
2019-11-18 17:50 ` Rob Herring
@ 2019-12-28 14:20 ` Andreas Färber
0 siblings, 0 replies; 5+ messages in thread
From: Andreas Färber @ 2019-12-28 14:20 UTC (permalink / raw)
To: Rob Herring, James Tai
Cc: Mark Rutland, 'DTML',
linux-realtek-soc, linux-kernel, linux-arm-kernel
Am 18.11.19 um 18:50 schrieb Rob Herring:
> On Tue, 12 Nov 2019 15:45:13 +0000, James Tai wrote:
>>
>> Define compatible strings for Realtek RTD1619 SoC and Realtek Mjolnir EVB.
>>
>> Signed-off-by: James Tai <james.tai@realtek.com>
>> ---
>> Documentation/devicetree/bindings/arm/realtek.yaml | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>
> Reviewed-by: Rob Herring <robh@kernel.org>
Applied to v5.6/dt:
https://git.kernel.org/pub/scm/linux/kernel/git/afaerber/linux-realtek.git/log/?h=v5.6/dt
Thanks,
Andreas
--
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-12-28 14:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-12 15:45 [PATCH v3 1/2] dt-bindings: arm: realtek: Document RTD1619 and Realtek Mjolnir EVB James Tai
2019-11-13 21:01 ` Andreas Färber
2019-11-15 14:42 ` James Tai
2019-11-18 17:50 ` Rob Herring
2019-12-28 14:20 ` Andreas Färber
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).