linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net] net: dsa: ocelot: add dependency for NET_DSA_MSCC_FELIX
@ 2019-11-19  2:51 Mao Wenan
  2019-11-19 23:41 ` David Miller
  0 siblings, 1 reply; 9+ messages in thread
From: Mao Wenan @ 2019-11-19  2:51 UTC (permalink / raw)
  To: vladimir.oltean, claudiu.manoil, andrew, vivien.didelot,
	f.fainelli, davem
  Cc: netdev, linux-kernel, kernel-janitors, Mao Wenan

If CONFIG_NET_DSA_MSCC_FELIX=y, and CONFIG_NET_VENDOR_MICROSEMI=n,
below errors can be found:
drivers/net/dsa/ocelot/felix.o: In function `felix_vlan_del':
felix.c:(.text+0x26e): undefined reference to `ocelot_vlan_del'
drivers/net/dsa/ocelot/felix.o: In function `felix_vlan_add':
felix.c:(.text+0x352): undefined reference to `ocelot_vlan_add'

and warning as below:
WARNING: unmet direct dependencies detected for MSCC_OCELOT_SWITCH
Depends on [n]: NETDEVICES [=y] && ETHERNET [=y] &&
NET_VENDOR_MICROSEMI [=n] && NET_SWITCHDEV [=y] && HAS_IOMEM [=y]
Selected by [y]:
NET_DSA_MSCC_FELIX [=y] && NETDEVICES [=y] && HAVE_NET_DSA [=y]
&& NET_DSA [=y] && PCI [=y]

This patch add dependency NET_VENDOR_MICROSEMI for NET_DSA_MSCC_FELIX.

Fixes: 56051948773e ("net: dsa: ocelot: add driver for Felix switch family")
Signed-off-by: Mao Wenan <maowenan@huawei.com>
---
 drivers/net/dsa/ocelot/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/dsa/ocelot/Kconfig b/drivers/net/dsa/ocelot/Kconfig
index 0031ca8..61c4ce7 100644
--- a/drivers/net/dsa/ocelot/Kconfig
+++ b/drivers/net/dsa/ocelot/Kconfig
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0-only
 config NET_DSA_MSCC_FELIX
 	tristate "Ocelot / Felix Ethernet switch support"
-	depends on NET_DSA && PCI
+	depends on NET_DSA && PCI && NET_VENDOR_MICROSEMI
 	select MSCC_OCELOT_SWITCH
 	select NET_DSA_TAG_OCELOT
 	help
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH net] net: dsa: ocelot: add dependency for NET_DSA_MSCC_FELIX
  2019-11-19  2:51 [PATCH net] net: dsa: ocelot: add dependency for NET_DSA_MSCC_FELIX Mao Wenan
@ 2019-11-19 23:41 ` David Miller
  2019-11-20  1:27   ` maowenan
  2019-11-20  1:47   ` [PATCH net v2] " Mao Wenan
  0 siblings, 2 replies; 9+ messages in thread
From: David Miller @ 2019-11-19 23:41 UTC (permalink / raw)
  To: maowenan
  Cc: vladimir.oltean, claudiu.manoil, andrew, vivien.didelot,
	f.fainelli, netdev, linux-kernel, kernel-janitors

From: Mao Wenan <maowenan@huawei.com>
Date: Tue, 19 Nov 2019 10:51:28 +0800

> If CONFIG_NET_DSA_MSCC_FELIX=y, and CONFIG_NET_VENDOR_MICROSEMI=n,
> below errors can be found:
> drivers/net/dsa/ocelot/felix.o: In function `felix_vlan_del':
> felix.c:(.text+0x26e): undefined reference to `ocelot_vlan_del'
> drivers/net/dsa/ocelot/felix.o: In function `felix_vlan_add':
> felix.c:(.text+0x352): undefined reference to `ocelot_vlan_add'
> 
> and warning as below:
> WARNING: unmet direct dependencies detected for MSCC_OCELOT_SWITCH
> Depends on [n]: NETDEVICES [=y] && ETHERNET [=y] &&
> NET_VENDOR_MICROSEMI [=n] && NET_SWITCHDEV [=y] && HAS_IOMEM [=y]
> Selected by [y]:
> NET_DSA_MSCC_FELIX [=y] && NETDEVICES [=y] && HAVE_NET_DSA [=y]
> && NET_DSA [=y] && PCI [=y]
> 
> This patch add dependency NET_VENDOR_MICROSEMI for NET_DSA_MSCC_FELIX.
> 
> Fixes: 56051948773e ("net: dsa: ocelot: add driver for Felix switch family")
> Signed-off-by: Mao Wenan <maowenan@huawei.com>

This seems more like a "select" situation, why in the world should the
user be required to know about NET_VENDOR_MISCROSEMI at all for this
driver?

And NET_VENDOR_MICROSEMI does _NOT_ enable any code at all, you have
to enable the individual drivers guarded by NET_VENDOR_MICROSEMI in order
to resolve the symbols necessary for ocelot.

I'm not applying this, it isn't correct.

Thank you.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH net] net: dsa: ocelot: add dependency for NET_DSA_MSCC_FELIX
  2019-11-19 23:41 ` David Miller
@ 2019-11-20  1:27   ` maowenan
  2019-11-20  1:47   ` [PATCH net v2] " Mao Wenan
  1 sibling, 0 replies; 9+ messages in thread
From: maowenan @ 2019-11-20  1:27 UTC (permalink / raw)
  To: David Miller
  Cc: vladimir.oltean, claudiu.manoil, andrew, vivien.didelot,
	f.fainelli, netdev, linux-kernel, kernel-janitors



在 2019/11/20 7:41, David Miller 写道:
> From: Mao Wenan <maowenan@huawei.com>
> Date: Tue, 19 Nov 2019 10:51:28 +0800
> 
>> If CONFIG_NET_DSA_MSCC_FELIX=y, and CONFIG_NET_VENDOR_MICROSEMI=n,
>> below errors can be found:
>> drivers/net/dsa/ocelot/felix.o: In function `felix_vlan_del':
>> felix.c:(.text+0x26e): undefined reference to `ocelot_vlan_del'
>> drivers/net/dsa/ocelot/felix.o: In function `felix_vlan_add':
>> felix.c:(.text+0x352): undefined reference to `ocelot_vlan_add'
>>
>> and warning as below:
>> WARNING: unmet direct dependencies detected for MSCC_OCELOT_SWITCH
>> Depends on [n]: NETDEVICES [=y] && ETHERNET [=y] &&
>> NET_VENDOR_MICROSEMI [=n] && NET_SWITCHDEV [=y] && HAS_IOMEM [=y]
>> Selected by [y]:
>> NET_DSA_MSCC_FELIX [=y] && NETDEVICES [=y] && HAVE_NET_DSA [=y]
>> && NET_DSA [=y] && PCI [=y]
>>
>> This patch add dependency NET_VENDOR_MICROSEMI for NET_DSA_MSCC_FELIX.
>>
>> Fixes: 56051948773e ("net: dsa: ocelot: add driver for Felix switch family")
>> Signed-off-by: Mao Wenan <maowenan@huawei.com>
> 
> This seems more like a "select" situation, why in the world should the
> user be required to know about NET_VENDOR_MISCROSEMI at all for this
> driver?
thanks.
I will change to 'select' it and send v2.
> 
> And NET_VENDOR_MICROSEMI does _NOT_ enable any code at all, you have
> to enable the individual drivers guarded by NET_VENDOR_MICROSEMI in order
> to resolve the symbols necessary for ocelot.
> 
> I'm not applying this, it isn't correct.
> 
> Thank you.
> 
> .
> 


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH net v2] net: dsa: ocelot: add dependency for NET_DSA_MSCC_FELIX
  2019-11-19 23:41 ` David Miller
  2019-11-20  1:27   ` maowenan
@ 2019-11-20  1:47   ` Mao Wenan
  2019-11-20  2:53     ` David Miller
  1 sibling, 1 reply; 9+ messages in thread
From: Mao Wenan @ 2019-11-20  1:47 UTC (permalink / raw)
  To: vladimir.oltean, claudiu.manoil, andrew, vivien.didelot,
	f.fainelli, davem
  Cc: netdev, linux-kernel, kernel-janitors, Mao Wenan

If CONFIG_NET_DSA_MSCC_FELIX=y, and CONFIG_NET_VENDOR_MICROSEMI=n,
below errors can be found:
drivers/net/dsa/ocelot/felix.o: In function `felix_vlan_del':
felix.c:(.text+0x26e): undefined reference to `ocelot_vlan_del'
drivers/net/dsa/ocelot/felix.o: In function `felix_vlan_add':
felix.c:(.text+0x352): undefined reference to `ocelot_vlan_add'

and warning as below:
WARNING: unmet direct dependencies detected for MSCC_OCELOT_SWITCH
Depends on [n]: NETDEVICES [=y] && ETHERNET [=y] &&
NET_VENDOR_MICROSEMI [=n] && NET_SWITCHDEV [=y] && HAS_IOMEM [=y]
Selected by [y]:
NET_DSA_MSCC_FELIX [=y] && NETDEVICES [=y] && HAVE_NET_DSA [=y]
&& NET_DSA [=y] && PCI [=y]

This patch is to select NET_VENDOR_MICROSEMI for NET_DSA_MSCC_FELIX.

Fixes: 56051948773e ("net: dsa: ocelot: add driver for Felix switch family")
Signed-off-by: Mao Wenan <maowenan@huawei.com>
---
 v2: modify 'depends on' to 'select'.
 drivers/net/dsa/ocelot/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/dsa/ocelot/Kconfig b/drivers/net/dsa/ocelot/Kconfig
index 0031ca8..652604b 100644
--- a/drivers/net/dsa/ocelot/Kconfig
+++ b/drivers/net/dsa/ocelot/Kconfig
@@ -2,6 +2,7 @@
 config NET_DSA_MSCC_FELIX
 	tristate "Ocelot / Felix Ethernet switch support"
 	depends on NET_DSA && PCI
+	select NET_VENDOR_MICROSEMI
 	select MSCC_OCELOT_SWITCH
 	select NET_DSA_TAG_OCELOT
 	help
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH net v2] net: dsa: ocelot: add dependency for NET_DSA_MSCC_FELIX
  2019-11-20  1:47   ` [PATCH net v2] " Mao Wenan
@ 2019-11-20  2:53     ` David Miller
  2019-11-20  9:38       ` maowenan
  0 siblings, 1 reply; 9+ messages in thread
From: David Miller @ 2019-11-20  2:53 UTC (permalink / raw)
  To: maowenan
  Cc: vladimir.oltean, claudiu.manoil, andrew, vivien.didelot,
	f.fainelli, netdev, linux-kernel, kernel-janitors

From: Mao Wenan <maowenan@huawei.com>
Date: Wed, 20 Nov 2019 09:47:22 +0800

> If CONFIG_NET_DSA_MSCC_FELIX=y, and CONFIG_NET_VENDOR_MICROSEMI=n,
> below errors can be found:
> drivers/net/dsa/ocelot/felix.o: In function `felix_vlan_del':
> felix.c:(.text+0x26e): undefined reference to `ocelot_vlan_del'
> drivers/net/dsa/ocelot/felix.o: In function `felix_vlan_add':
> felix.c:(.text+0x352): undefined reference to `ocelot_vlan_add'
> 
> and warning as below:
> WARNING: unmet direct dependencies detected for MSCC_OCELOT_SWITCH
> Depends on [n]: NETDEVICES [=y] && ETHERNET [=y] &&
> NET_VENDOR_MICROSEMI [=n] && NET_SWITCHDEV [=y] && HAS_IOMEM [=y]
> Selected by [y]:
> NET_DSA_MSCC_FELIX [=y] && NETDEVICES [=y] && HAVE_NET_DSA [=y]
> && NET_DSA [=y] && PCI [=y]
> 
> This patch is to select NET_VENDOR_MICROSEMI for NET_DSA_MSCC_FELIX.
> 
> Fixes: 56051948773e ("net: dsa: ocelot: add driver for Felix switch family")
> Signed-off-by: Mao Wenan <maowenan@huawei.com>

You did not read my feedback, read it again please.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH net v2] net: dsa: ocelot: add dependency for NET_DSA_MSCC_FELIX
  2019-11-20  2:53     ` David Miller
@ 2019-11-20  9:38       ` maowenan
  2019-11-25 12:41         ` [PATCH net v3] " Mao Wenan
  0 siblings, 1 reply; 9+ messages in thread
From: maowenan @ 2019-11-20  9:38 UTC (permalink / raw)
  To: David Miller
  Cc: vladimir.oltean, claudiu.manoil, andrew, vivien.didelot,
	f.fainelli, netdev, linux-kernel, kernel-janitors



在 2019/11/20 10:53, David Miller 写道:
> From: Mao Wenan <maowenan@huawei.com>
> Date: Wed, 20 Nov 2019 09:47:22 +0800
> 
>> If CONFIG_NET_DSA_MSCC_FELIX=y, and CONFIG_NET_VENDOR_MICROSEMI=n,
>> below errors can be found:
>> drivers/net/dsa/ocelot/felix.o: In function `felix_vlan_del':
>> felix.c:(.text+0x26e): undefined reference to `ocelot_vlan_del'
>> drivers/net/dsa/ocelot/felix.o: In function `felix_vlan_add':
>> felix.c:(.text+0x352): undefined reference to `ocelot_vlan_add'
>>
>> and warning as below:
>> WARNING: unmet direct dependencies detected for MSCC_OCELOT_SWITCH
>> Depends on [n]: NETDEVICES [=y] && ETHERNET [=y] &&
>> NET_VENDOR_MICROSEMI [=n] && NET_SWITCHDEV [=y] && HAS_IOMEM [=y]
>> Selected by [y]:
>> NET_DSA_MSCC_FELIX [=y] && NETDEVICES [=y] && HAVE_NET_DSA [=y]
>> && NET_DSA [=y] && PCI [=y]
>>
>> This patch is to select NET_VENDOR_MICROSEMI for NET_DSA_MSCC_FELIX.
>>
>> Fixes: 56051948773e ("net: dsa: ocelot: add driver for Felix switch family")
>> Signed-off-by: Mao Wenan <maowenan@huawei.com>
> 
> You did not read my feedback, read it again please.
Sorry for that, do you mean firstly to resolve dependencies according to MSCC_OCELOT_SWITCH,
config MSCC_OCELOT_SWITCH
        tristate "Ocelot switch driver"
        depends on NET_SWITCHDEV
        depends on HAS_IOMEM

after that to select in MSCC_OCELOT_SWITCH in NET_DSA_MSCC_FELIX,
config NET_DSA_MSCC_FELIX
        tristate "Ocelot / Felix Ethernet switch support"
        depends on NET_DSA && PCI
+	select NET_VENDOR_MICROSEMI
+       depends on NET_SWITCHDEV
+	depends on HAS_IOMEM
        select MSCC_OCELOT_SWITCH
        select NET_DSA_TAG_OCELOT
        help


> 
> .
> 


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH net v3] net: dsa: ocelot: add dependency for NET_DSA_MSCC_FELIX
  2019-11-20  9:38       ` maowenan
@ 2019-11-25 12:41         ` Mao Wenan
  2019-11-25 19:05           ` David Miller
  2019-11-25 19:42           ` Vladimir Oltean
  0 siblings, 2 replies; 9+ messages in thread
From: Mao Wenan @ 2019-11-25 12:41 UTC (permalink / raw)
  To: vladimir.oltean, claudiu.manoil, andrew, vivien.didelot,
	f.fainelli, davem
  Cc: netdev, linux-kernel, kernel-janitors, Mao Wenan

If CONFIG_NET_DSA_MSCC_FELIX=y, and CONFIG_NET_VENDOR_MICROSEMI=n,
below errors can be found:
drivers/net/dsa/ocelot/felix.o: In function `felix_vlan_del':
felix.c:(.text+0x26e): undefined reference to `ocelot_vlan_del'
drivers/net/dsa/ocelot/felix.o: In function `felix_vlan_add':
felix.c:(.text+0x352): undefined reference to `ocelot_vlan_add'

and warning as below:
WARNING: unmet direct dependencies detected for MSCC_OCELOT_SWITCH
Depends on [n]: NETDEVICES [=y] && ETHERNET [=y] &&
NET_VENDOR_MICROSEMI [=n] && NET_SWITCHDEV [=y] && HAS_IOMEM [=y]
Selected by [y]:
NET_DSA_MSCC_FELIX [=y] && NETDEVICES [=y] && HAVE_NET_DSA [=y]
&& NET_DSA [=y] && PCI [=y]

This patch is to select NET_VENDOR_MICROSEMI and add dependency
NET_SWITCHDEV, HAS_IOMEM for NET_DSA_MSCC_FELIX.

Fixes: 56051948773e ("net: dsa: ocelot: add driver for Felix switch family")
Signed-off-by: Mao Wenan <maowenan@huawei.com>
---
 v3: add depends on NET_SWITCHDEV and HAS_IOMEM.
 v2: modify 'depends on' to 'select'.
 drivers/net/dsa/ocelot/Kconfig | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/dsa/ocelot/Kconfig b/drivers/net/dsa/ocelot/Kconfig
index 0031ca814346..1ec2dfbd76ce 100644
--- a/drivers/net/dsa/ocelot/Kconfig
+++ b/drivers/net/dsa/ocelot/Kconfig
@@ -2,6 +2,9 @@
 config NET_DSA_MSCC_FELIX
 	tristate "Ocelot / Felix Ethernet switch support"
 	depends on NET_DSA && PCI
+	depends on NET_SWITCHDEV
+	depends on HAS_IOMEM
+	select NET_VENDOR_MICROSEMI
 	select MSCC_OCELOT_SWITCH
 	select NET_DSA_TAG_OCELOT
 	help
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH net v3] net: dsa: ocelot: add dependency for NET_DSA_MSCC_FELIX
  2019-11-25 12:41         ` [PATCH net v3] " Mao Wenan
@ 2019-11-25 19:05           ` David Miller
  2019-11-25 19:42           ` Vladimir Oltean
  1 sibling, 0 replies; 9+ messages in thread
From: David Miller @ 2019-11-25 19:05 UTC (permalink / raw)
  To: maowenan
  Cc: vladimir.oltean, claudiu.manoil, andrew, vivien.didelot,
	f.fainelli, netdev, linux-kernel, kernel-janitors

From: Mao Wenan <maowenan@huawei.com>
Date: Mon, 25 Nov 2019 20:41:10 +0800

> +	select NET_VENDOR_MICROSEMI

This is never correct.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH net v3] net: dsa: ocelot: add dependency for NET_DSA_MSCC_FELIX
  2019-11-25 12:41         ` [PATCH net v3] " Mao Wenan
  2019-11-25 19:05           ` David Miller
@ 2019-11-25 19:42           ` Vladimir Oltean
  1 sibling, 0 replies; 9+ messages in thread
From: Vladimir Oltean @ 2019-11-25 19:42 UTC (permalink / raw)
  To: Mao Wenan
  Cc: Vladimir Oltean, Claudiu Manoil, Andrew Lunn, Vivien Didelot,
	Florian Fainelli, David S. Miller, netdev, lkml, kernel-janitors

On Mon, 25 Nov 2019 at 14:47, Mao Wenan <maowenan@huawei.com> wrote:
>
> If CONFIG_NET_DSA_MSCC_FELIX=y, and CONFIG_NET_VENDOR_MICROSEMI=n,
> below errors can be found:
> drivers/net/dsa/ocelot/felix.o: In function `felix_vlan_del':
> felix.c:(.text+0x26e): undefined reference to `ocelot_vlan_del'
> drivers/net/dsa/ocelot/felix.o: In function `felix_vlan_add':
> felix.c:(.text+0x352): undefined reference to `ocelot_vlan_add'
>
> and warning as below:
> WARNING: unmet direct dependencies detected for MSCC_OCELOT_SWITCH
> Depends on [n]: NETDEVICES [=y] && ETHERNET [=y] &&
> NET_VENDOR_MICROSEMI [=n] && NET_SWITCHDEV [=y] && HAS_IOMEM [=y]
> Selected by [y]:
> NET_DSA_MSCC_FELIX [=y] && NETDEVICES [=y] && HAVE_NET_DSA [=y]
> && NET_DSA [=y] && PCI [=y]
>
> This patch is to select NET_VENDOR_MICROSEMI and add dependency
> NET_SWITCHDEV, HAS_IOMEM for NET_DSA_MSCC_FELIX.
>
> Fixes: 56051948773e ("net: dsa: ocelot: add driver for Felix switch family")
> Signed-off-by: Mao Wenan <maowenan@huawei.com>
> ---

NET_DSA already selects NET_SWITCHDEV
MSCC_OCELOT_SWITCH already selects HAS_IOMEM
As for NET_VENDOR_MICROSEMI, does anyone care what are the results
after Kconfig prints this?

WARNING: unmet direct dependencies detected for MSCC_OCELOT_SWITCH
  Depends on [n]: NETDEVICES [=y] && ETHERNET [=y] &&
NET_VENDOR_MICROSEMI [=n] && NET_SWITCHDEV [=y] && HAS_IOMEM [=y]
  Selected by [y]:
  - NET_DSA_MSCC_FELIX [=y] && NETDEVICES [=y] && HAVE_NET_DSA [=y] &&
NET_DSA [=y] && PCI [=y]

WARNING: unmet direct dependencies detected for MSCC_OCELOT_SWITCH
  Depends on [n]: NETDEVICES [=y] && ETHERNET [=y] &&
NET_VENDOR_MICROSEMI [=n] && NET_SWITCHDEV [=y] && HAS_IOMEM [=y]
  Selected by [y]:
  - NET_DSA_MSCC_FELIX [=y] && NETDEVICES [=y] && HAVE_NET_DSA [=y] &&
NET_DSA [=y] && PCI [=y]

WARNING: unmet direct dependencies detected for MSCC_OCELOT_SWITCH
  Depends on [n]: NETDEVICES [=y] && ETHERNET [=y] &&
NET_VENDOR_MICROSEMI [=n] && NET_SWITCHDEV [=y] && HAS_IOMEM [=y]
  Selected by [y]:
  - NET_DSA_MSCC_FELIX [=y] && NETDEVICES [=y] && HAVE_NET_DSA [=y] &&
NET_DSA [=y] && PCI [=y]

If yes. why?

It's like executing code after return.

>  v3: add depends on NET_SWITCHDEV and HAS_IOMEM.
>  v2: modify 'depends on' to 'select'.
>  drivers/net/dsa/ocelot/Kconfig | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/dsa/ocelot/Kconfig b/drivers/net/dsa/ocelot/Kconfig
> index 0031ca814346..1ec2dfbd76ce 100644
> --- a/drivers/net/dsa/ocelot/Kconfig
> +++ b/drivers/net/dsa/ocelot/Kconfig
> @@ -2,6 +2,9 @@
>  config NET_DSA_MSCC_FELIX
>         tristate "Ocelot / Felix Ethernet switch support"
>         depends on NET_DSA && PCI
> +       depends on NET_SWITCHDEV
> +       depends on HAS_IOMEM
> +       select NET_VENDOR_MICROSEMI
>         select MSCC_OCELOT_SWITCH
>         select NET_DSA_TAG_OCELOT
>         help
> --
> 2.20.1
>

Regards,
-Vladimir

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2019-11-25 19:42 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-19  2:51 [PATCH net] net: dsa: ocelot: add dependency for NET_DSA_MSCC_FELIX Mao Wenan
2019-11-19 23:41 ` David Miller
2019-11-20  1:27   ` maowenan
2019-11-20  1:47   ` [PATCH net v2] " Mao Wenan
2019-11-20  2:53     ` David Miller
2019-11-20  9:38       ` maowenan
2019-11-25 12:41         ` [PATCH net v3] " Mao Wenan
2019-11-25 19:05           ` David Miller
2019-11-25 19:42           ` Vladimir Oltean

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).