From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17C9CC432C0 for ; Tue, 19 Nov 2019 05:44:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E3BF0222ED for ; Tue, 19 Nov 2019 05:44:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574142255; bh=TSFsAvaGBmZ6vHG8Bcr9uENl0LS1+W5Kq8pB0n3HhdE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=FUqZ5WUtLHGyqnSKIj7gf7KN+nS/NbQw/QnOgtI6LtXzaZpXW/vLExpT8TAs3CXMw 2WvQpUBhF4H72IF8rXATEDWUkt/toGJBR8Y6SE4G9YKdbbTnu2kxw8u0vVMj79paq1 r7VU99fZd+QuR7OqpcKMV97vxjK9G6Ty0YfjlBMA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730592AbfKSFoO (ORCPT ); Tue, 19 Nov 2019 00:44:14 -0500 Received: from mail.kernel.org ([198.145.29.99]:39464 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730291AbfKSFoL (ORCPT ); Tue, 19 Nov 2019 00:44:11 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B50D3222A4; Tue, 19 Nov 2019 05:44:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574142250; bh=TSFsAvaGBmZ6vHG8Bcr9uENl0LS1+W5Kq8pB0n3HhdE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MNcAUoCbh+ld3+4KRU2Tbced4ht7ps8wpoN+9oB7VZWvLzupGOC5YWO+n3Hq5P52g B04n6/UTrJis69DSx9eXGEW3IQJJm3EcZocpB+13MIa+ytIt3609U7OsYHOd1EB/YI oj6xqaoxFvmNCLMmC2keZ5TO9hulbXRh10UVt9Ek= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Chuhong Yuan , Dmitry Torokhov Subject: [PATCH 4.14 018/239] Input: synaptics-rmi4 - destroy F54 poller workqueue when removing Date: Tue, 19 Nov 2019 06:16:58 +0100 Message-Id: <20191119051301.143335244@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191119051255.850204959@linuxfoundation.org> References: <20191119051255.850204959@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chuhong Yuan commit ba60cf9f78f0d7c8e73c7390608f7f818ee68aa0 upstream. The driver forgets to destroy workqueue in remove() similarly to what is done when probe() fails. Add a call to destroy_workqueue() to fix it. Since unregistration will wait for the work to finish, we do not need to cancel/flush the work instance in remove(). Signed-off-by: Chuhong Yuan Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20191114023405.31477-1-hslester96@gmail.com Signed-off-by: Dmitry Torokhov Signed-off-by: Greg Kroah-Hartman --- drivers/input/rmi4/rmi_f54.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/input/rmi4/rmi_f54.c +++ b/drivers/input/rmi4/rmi_f54.c @@ -747,6 +747,7 @@ static void rmi_f54_remove(struct rmi_fu video_unregister_device(&f54->vdev); v4l2_device_unregister(&f54->v4l2); + destroy_workqueue(f54->workqueue); } struct rmi_function_handler rmi_f54_handler = {