From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55A8EC43141 for ; Tue, 19 Nov 2019 05:23:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1E38B21939 for ; Tue, 19 Nov 2019 05:23:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574141008; bh=ADyp6Rzsx2MfrdWW4FOXRRHYUFvd+5cFilVBnnNmt8I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=OU1zBhEwOZR0xn2J21NKgscWvuTkr7Vuy8ks+h0wbv48JmLqbLuDXrT88ZY9QH5Ug DAbbevp+6Mackv9/NF57OIyQhWIwmZwHpEaFlXhkUPMubkuR8FlobTIdrHHiFuf915 A4codMMWcpcIEChwb5McDy7NZvHiZmEOuFqxp4MY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727992AbfKSFX0 (ORCPT ); Tue, 19 Nov 2019 00:23:26 -0500 Received: from mail.kernel.org ([198.145.29.99]:39036 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727983AbfKSFXY (ORCPT ); Tue, 19 Nov 2019 00:23:24 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 84A7B22323; Tue, 19 Nov 2019 05:23:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574141004; bh=ADyp6Rzsx2MfrdWW4FOXRRHYUFvd+5cFilVBnnNmt8I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bCYAfDW9d4kLC+kXdbVSqy7oI/l53EOjK1IpR9UFVqMvEeihfro2CwX9nM+tEg7R9 bks/pzYPuH5eA/MZku/zAJ44PTwUkH/7yGuVum5FK0MDouwsGIYLPt8Oj8AJEl3nV1 79xmifGpu2GiDqkA3l/6/3aRSvMI+hfXDhJVBYMM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+a8d4acdad35e6bbca308@syzkaller.appspotmail.com, Oliver Neukum , "David S. Miller" Subject: [PATCH 4.19 004/422] ax88172a: fix information leak on short answers Date: Tue, 19 Nov 2019 06:13:21 +0100 Message-Id: <20191119051400.509451837@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191119051400.261610025@linuxfoundation.org> References: <20191119051400.261610025@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Oliver Neukum [ Upstream commit a9a51bd727d141a67b589f375fe69d0e54c4fe22 ] If a malicious device gives a short MAC it can elicit up to 5 bytes of leaked memory out of the driver. We need to check for ETH_ALEN instead. Reported-by: syzbot+a8d4acdad35e6bbca308@syzkaller.appspotmail.com Signed-off-by: Oliver Neukum Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/usb/ax88172a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/usb/ax88172a.c +++ b/drivers/net/usb/ax88172a.c @@ -208,7 +208,7 @@ static int ax88172a_bind(struct usbnet * /* Get the MAC address */ ret = asix_read_cmd(dev, AX_CMD_READ_NODE_ID, 0, 0, ETH_ALEN, buf, 0); - if (ret < 0) { + if (ret < ETH_ALEN) { netdev_err(dev->net, "Failed to read MAC address: %d\n", ret); goto free; }