From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F7E6C432C0 for ; Tue, 19 Nov 2019 05:35:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3DA4320862 for ; Tue, 19 Nov 2019 05:35:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574141720; bh=+mucMr6A/hRINmaccGje7YrhL8FrsBd+/9b1Se5ecYw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=JELx9ItM+nB4xkcnC8iSsrmaVYp1xzjdlPNHOErLIcmA9VjR9/VorIWiV4lNJXLqQ AvJ/oJoo+3riebiWgpKJFP9LTqK6Q17voxAEtsrJg7cOJwtLORcK3Yt320EB2bRUnc Y3rGZGcR3waxO3QynZqwOSYswbaLOQpw6QfVKPD8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729800AbfKSFfT (ORCPT ); Tue, 19 Nov 2019 00:35:19 -0500 Received: from mail.kernel.org ([198.145.29.99]:56154 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728251AbfKSFfQ (ORCPT ); Tue, 19 Nov 2019 00:35:16 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 59DC721783; Tue, 19 Nov 2019 05:35:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574141715; bh=+mucMr6A/hRINmaccGje7YrhL8FrsBd+/9b1Se5ecYw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=T4PPQ0NzvEVUXgGeKpCFMyCsshLP0lNawGRLinKoSFoF2plkvMKjcV4hpLJLs1Rdj R+LZwzs3TrvF5MN1p7EfXr/BzhImkI771QMCkrmdJfLVvqAvr7yz8FSsyAcIAKkQbI kpgbWR/53xOLN3mtHm2HxqXD2MXHhuNnTcsuO+Ig= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Corey Minyard , Sasha Levin Subject: [PATCH 4.19 255/422] ipmi:dmi: Ignore IPMI SMBIOS entries with a zero base address Date: Tue, 19 Nov 2019 06:17:32 +0100 Message-Id: <20191119051415.511427735@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191119051400.261610025@linuxfoundation.org> References: <20191119051400.261610025@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Corey Minyard [ Upstream commit 1574608f5f4204440d6d9f52b971aba967664764 ] Looking at logs from systems all over the place, it looks like tons of broken systems exist that set the base address to zero. I can only guess that is some sort of non-standard idea to mark the interface as not being present. It can't be zero, anyway, so just complain and ignore it. Signed-off-by: Corey Minyard Signed-off-by: Sasha Levin --- drivers/char/ipmi/ipmi_dmi.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/char/ipmi/ipmi_dmi.c b/drivers/char/ipmi/ipmi_dmi.c index e2c143861b1e5..28dbd5529188a 100644 --- a/drivers/char/ipmi/ipmi_dmi.c +++ b/drivers/char/ipmi/ipmi_dmi.c @@ -217,6 +217,10 @@ static void __init dmi_decode_ipmi(const struct dmi_header *dm) slave_addr = data[DMI_IPMI_SLAVEADDR]; memcpy(&base_addr, data + DMI_IPMI_ADDR, sizeof(unsigned long)); + if (!base_addr) { + pr_err("Base address is zero, assuming no IPMI interface\n"); + return; + } if (len >= DMI_IPMI_VER2_LENGTH) { if (type == IPMI_DMI_TYPE_SSIF) { offset = 0; -- 2.20.1