From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0494FC432C0 for ; Tue, 19 Nov 2019 05:42:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CC3A321783 for ; Tue, 19 Nov 2019 05:42:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574142133; bh=laLOVN9b3e7blkEA0eFOdsXXjtlukZsyKhx2FPSNf5o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=jnuA2wOoQKZ4mBTTuGjKxrg7HhBKhKz1MDfehIYIxAYtA2K+fNg8I2TLUTBNMpLXo b9/BK3SID9GLtezpaCrpyAUd7WBsYqcIWQFdNI2Y4LrlmVSnLG2LOi+F+lFTGWKTCc JX9uSbt96x+6J9U0HeSNLU4cAoY+rHJgkXPR5ubM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730611AbfKSFmM (ORCPT ); Tue, 19 Nov 2019 00:42:12 -0500 Received: from mail.kernel.org ([198.145.29.99]:36812 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728825AbfKSFmK (ORCPT ); Tue, 19 Nov 2019 00:42:10 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 378C421783; Tue, 19 Nov 2019 05:42:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574142129; bh=laLOVN9b3e7blkEA0eFOdsXXjtlukZsyKhx2FPSNf5o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Z8joRWgeBgiWVyDKc4b50hSfiftwcRgc/zZbLE9USofkfMb/UWBumKCXEf7KMCLah OgyjztljMMcmHnKgYZBp8vbk4IFdAQ8IhqVwdxsmlultnJcRAcBKHCp5iy2wLbJ2/b SL9eOPm9VKjTjOpEKH/AXztB7qWoASkPqJrfE1bg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Li Qiang , Eric Auger , Alex Williamson , Sasha Levin Subject: [PATCH 4.19 358/422] vfio/pci: Fix potential memory leak in vfio_msi_cap_len Date: Tue, 19 Nov 2019 06:19:15 +0100 Message-Id: <20191119051422.215326869@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191119051400.261610025@linuxfoundation.org> References: <20191119051400.261610025@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Li Qiang [ Upstream commit 30ea32ab1951c80c6113f300fce2c70cd12659e4 ] Free allocated vdev->msi_perm in error path. Signed-off-by: Li Qiang Reviewed-by: Eric Auger Signed-off-by: Alex Williamson Signed-off-by: Sasha Levin --- drivers/vfio/pci/vfio_pci_config.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/vfio/pci/vfio_pci_config.c b/drivers/vfio/pci/vfio_pci_config.c index 115a36f6f4039..62023b4a373b4 100644 --- a/drivers/vfio/pci/vfio_pci_config.c +++ b/drivers/vfio/pci/vfio_pci_config.c @@ -1180,8 +1180,10 @@ static int vfio_msi_cap_len(struct vfio_pci_device *vdev, u8 pos) return -ENOMEM; ret = init_pci_cap_msi_perm(vdev->msi_perm, len, flags); - if (ret) + if (ret) { + kfree(vdev->msi_perm); return ret; + } return len; } -- 2.20.1