From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE9A9C432C0 for ; Tue, 19 Nov 2019 06:02:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 76D0520872 for ; Tue, 19 Nov 2019 06:02:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574143338; bh=FsKtONwnJ0E+3juQFQYvpQtt820kG0TE5BDmYoercLA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=1Ih4zofjb6de5TE1W98xTbQiQ2SAUiU80Bp90mJg7/AqyB3r1GVWHLVwl6y0iHEMl yfqY1NXOoI5CygqLogYSHreoX23Yw8bH5aqJV3cV7UsrxBJSw9lB2AXglxoHQ90T8e QXpUwWnCOrvSI2AOLj3rLw+5toL/lRcsG1qa36lU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730648AbfKSFmf (ORCPT ); Tue, 19 Nov 2019 00:42:35 -0500 Received: from mail.kernel.org ([198.145.29.99]:37244 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730077AbfKSFma (ORCPT ); Tue, 19 Nov 2019 00:42:30 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 13CAA21783; Tue, 19 Nov 2019 05:42:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574142149; bh=FsKtONwnJ0E+3juQFQYvpQtt820kG0TE5BDmYoercLA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pQW7XKiCztl+5fWSww0N5F9SP6okNL49+ETU6x3fakvj18vU2/GxpgsTBNJQElC3j cTr+TKs29EF4bwmyqjh6fjOe0aPwfNSECFJ43ayhe2Wv/q57SjccPi2QDb2/8JBau0 PnKXUFmY2D5QfprRtFt3fusQWo3SCX7ykzSwtVVs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Michael Schmitz , Finn Thain , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 4.19 406/422] scsi: NCR5380: Handle BUS FREE during reselection Date: Tue, 19 Nov 2019 06:20:03 +0100 Message-Id: <20191119051425.489299340@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191119051400.261610025@linuxfoundation.org> References: <20191119051400.261610025@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Finn Thain [ Upstream commit ca694afad707cb3ae2fdef3b28454444d9ac726e ] The X3T9.2 specification (draft) says, under "6.1.4.2 RESELECTION time-out procedure", that a target may assert RST or go to BUS FREE phase if the initiator does not respond within 200 us. Something like this has been observed with AztecMonster II target. When it happens, all we can do is wait for the target to try again. Tested-by: Michael Schmitz Signed-off-by: Finn Thain Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/NCR5380.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c index 5c3ffb466bb10..bce6c990d060a 100644 --- a/drivers/scsi/NCR5380.c +++ b/drivers/scsi/NCR5380.c @@ -2039,6 +2039,9 @@ static void NCR5380_reselect(struct Scsi_Host *instance) if (NCR5380_poll_politely(hostdata, STATUS_REG, SR_REQ, SR_REQ, 2 * HZ) < 0) { + if ((NCR5380_read(STATUS_REG) & (SR_BSY | SR_SEL)) == 0) + /* BUS FREE phase */ + return; shost_printk(KERN_ERR, instance, "reselect: REQ timeout\n"); do_abort(instance); return; -- 2.20.1