From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 657A9C432C0 for ; Tue, 19 Nov 2019 17:02:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 43F6F208D4 for ; Tue, 19 Nov 2019 17:02:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728580AbfKSRCC (ORCPT ); Tue, 19 Nov 2019 12:02:02 -0500 Received: from mga03.intel.com ([134.134.136.65]:23294 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728071AbfKSRCB (ORCPT ); Tue, 19 Nov 2019 12:02:01 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Nov 2019 09:01:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,218,1571727600"; d="scan'208";a="289664932" Received: from jacob-builder.jf.intel.com (HELO jacob-builder) ([10.7.199.155]) by orsmga001.jf.intel.com with ESMTP; 19 Nov 2019 09:01:53 -0800 Date: Tue, 19 Nov 2019 09:06:28 -0800 From: Jacob Pan To: Lu Baolu Cc: Auger Eric , iommu@lists.linux-foundation.org, LKML , Joerg Roedel , David Woodhouse , "Tian, Kevin" , Raj Ashok , Yi Liu , jacob.jun.pan@linux.intel.com Subject: Re: [PATCH v2 01/10] iommu/vt-d: Introduce native SVM capable flag Message-ID: <20191119090628.7295cd7d@jacob-builder> In-Reply-To: References: <1574106153-45867-1-git-send-email-jacob.jun.pan@linux.intel.com> <1574106153-45867-2-git-send-email-jacob.jun.pan@linux.intel.com> <20191118134809.66b9fda4@jacob-builder> Organization: OTC X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 19 Nov 2019 10:55:29 +0800 Lu Baolu wrote: > Hi, > > On 11/19/19 5:48 AM, Jacob Pan wrote: > > On Mon, 18 Nov 2019 21:33:53 +0100 > > Auger Eric wrote: > > > >> Hi Jacob, > >> > >> On 11/18/19 8:42 PM, Jacob Pan wrote: > >>> Shared Virtual Memory(SVM) is based on a collective set of > >>> hardware features detected at runtime. There are requirements for > >>> matching CPU and IOMMU capabilities. > >>> > >>> This patch introduces a flag which will be used to mark and test > >>> the capability of SVM. > >>> > >>> Signed-off-by: Jacob Pan > >>> Acked-by: Lu Baolu > >>> --- > >>> include/linux/intel-iommu.h | 1 + > >>> 1 file changed, 1 insertion(+) > >>> > >>> diff --git a/include/linux/intel-iommu.h > >>> b/include/linux/intel-iommu.h index ed11ef594378..63118991824c > >>> 100644 --- a/include/linux/intel-iommu.h > >>> +++ b/include/linux/intel-iommu.h > >>> @@ -433,6 +433,7 @@ enum { > >>> > >>> #define VTD_FLAG_TRANS_PRE_ENABLED (1 << 0) > >>> #define VTD_FLAG_IRQ_REMAP_PRE_ENABLED (1 << 1) > >>> +#define VTD_FLAG_SVM_CAPABLE (1 << 2) > >> > >> I think I would rather squash this into the next patch as there is > >> no user here. > >> > > Sure, I don't have strong preference. Baolu, what is your call? > > It's okay for me. > will squash then. Thanks! > Best regards, > baolu [Jacob Pan]