From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED254C432C0 for ; Tue, 19 Nov 2019 12:41:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B64F1222B5 for ; Tue, 19 Nov 2019 12:41:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574167315; bh=jIhRA2VwaLRoYAsN0KyguVUzU+5d8qr8uraCIb163JA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=a3025+xUsbHVwck/5EDQJc3YXdyGqQvdKvNoFLeC4C+MCslrzn21SBR4Ny34g3Xke ABxGWnsISQ+dg7JEfWelNku2PzdcI54uPUrFMnbtYvRCXTql8qd0H4RJOTDsv6Fkjq jb0k48d0ISSfxDU5DovG8m+C7fLMKmufvpvJVb4s= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728003AbfKSMly (ORCPT ); Tue, 19 Nov 2019 07:41:54 -0500 Received: from mail.kernel.org ([198.145.29.99]:34684 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725280AbfKSMly (ORCPT ); Tue, 19 Nov 2019 07:41:54 -0500 Received: from localhost (unknown [89.205.136.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D351421D7B; Tue, 19 Nov 2019 12:41:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574167313; bh=jIhRA2VwaLRoYAsN0KyguVUzU+5d8qr8uraCIb163JA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gqZ15+AB9gEx214RhI/6BiIld+DI3r8SCSyl30Sf8k1vshnIZ2+FvimgC0q7d6HYr 2oWTxdvy9cvWFmdKRLSP00W1sVGYzsuzMiAGtxi/P2qzcYTsjtownsUArlI4rB4Q6d CCIMBEXBglKack0f6GwI6WeQVE0krS4PINE+Ku8c= Date: Tue, 19 Nov 2019 13:41:50 +0100 From: Greg Kroah-Hartman To: Andy Lutomirski Cc: Stephan =?iso-8859-1?Q?M=FCller?= , Arnd Bergmann , Linux Crypto Mailing List , LKML , Linux API , "Eric W. Biederman" , "Alexander E. Patrakov" , "Ahmed S. Darwish" , "Theodore Y. Ts'o" , Willy Tarreau , Matthew Garrett , Vito Caputo , Andreas Dilger , Jan Kara , Ray Strode , William Jon McCann , zhangjs , Florian Weimer , Lennart Poettering , Nicolai Stange , "Peter, Matthias" , Marcelo Henrique Cerri , Roman Drahtmueller , Neil Horman Subject: Re: [PATCH v25 10/12] LRNG - add TRNG support Message-ID: <20191119124150.GB1975017@kroah.com> References: <5390778.VeFRgus4bQ@positron.chronox.de> <3159012.PsEOTp9LqO@positron.chronox.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 19, 2019 at 02:07:40AM -0800, Andy Lutomirski wrote: > > As this would introduce a new device file now, is there a special process that > > I need to follow or do I need to copy? Which major/minor number should I use? > > > > Looking into static const struct memdev devlist[] I see > > > > [8] = { "random", 0666, &random_fops, 0 }, > > [9] = { "urandom", 0666, &urandom_fops, 0 }, > > > > Shall a true_random be added here with [10]? > > I am not at all an expert on chardevs, but this sounds generally > reasonable. gregkh is probably the real authority here. [10] is the aio char device node, so you better not try to overlap it or bad things will happen :( thanks, greg k-h