From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D805EC432C3 for ; Tue, 19 Nov 2019 17:53:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B35162231D for ; Tue, 19 Nov 2019 17:53:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YtWcSQnI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727579AbfKSRxa (ORCPT ); Tue, 19 Nov 2019 12:53:30 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:34612 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727007AbfKSRx3 (ORCPT ); Tue, 19 Nov 2019 12:53:29 -0500 Received: by mail-wr1-f68.google.com with SMTP id e6so24992321wrw.1; Tue, 19 Nov 2019 09:53:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nFDrmtiB5h/Zr80zbuCGUX75SrtWuuQxETq8orGACdo=; b=YtWcSQnI6pXUARGVokPA5sc6sJqKiwcAGEZYpo6ywyxt4+5YqjDAlaXPKMFD1vYyag 2Mr/4CjKk7dJLtfCfn/QxO/0Qp/+/jUChWLRiMIjnGhg2bO7rysomkyJljQpsv5c/ZED vJ0eSh5q+6TZ1bWgnNXb3ldlRHd8f1I4ULlY6AAcSjAfyDrt5+HTLEypkypaceRlBXdj PzU+UHw29mV9PTRk/0BgEYQ+0oVwf8ch0WxeEoaGkeXhWPXW22DBh2taXEolCS7wvFiv ykBZjmTbEG1/A545uNLv8wOsLRq09Ptr0G9uZ+oApPys4ZXJTlzRX2OSOOxBO+618u06 DFQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nFDrmtiB5h/Zr80zbuCGUX75SrtWuuQxETq8orGACdo=; b=hMuA1t0sa3RcTVMvtlOEmlO+4VYe83GrUr6ENo5rxyM8sP3o8pRAaQ8KGOIPMBSWsq t+qSDHpBPikp2q7LR3EG6khJ0iz38fPCclPkcGX095XzV9YPmpEqKsMEGDgkRDvcRbnr 6V8cRVfFmDGeNSXoMG8MdE7ZU8lqgzBk3Ia0PzLaZbHp06vkPo11NtzskRlPpOpEbbIs LLIYJ1LYQ/BhOMxEQNDBSl0Arf7DZ6s0lyQ1pud3Q87Ec4F2QH3CUGNTbEBInTu+6eTO qR0byAQVN3rA3Kko2fPmpiceyt050x6+tzc4jhqYyBxrQm6WGuPW5NWYFUjMp+5fCXKg P/UA== X-Gm-Message-State: APjAAAWCTQjCQU011qmzQTXMh1p+6GHCKdjttUjp0DxelgEjAjxomqig kd/5LAqWaVZ0K8IZhVuQd8Y= X-Google-Smtp-Source: APXvYqzTJFqhXrrlq0ftpNdro0ODeqnvh2+LUQyS9Y4HxRGQJ38Jh0DSAqFFjpPJR3D9IFQyvA8rpA== X-Received: by 2002:adf:efcb:: with SMTP id i11mr17605497wrp.229.1574186005947; Tue, 19 Nov 2019 09:53:25 -0800 (PST) Received: from clement-Latitude-7490.outsight.local (lputeaux-656-1-11-33.w82-127.abo.wanadoo.fr. [82.127.142.33]) by smtp.gmail.com with ESMTPSA id l13sm3772618wmh.12.2019.11.19.09.53.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Nov 2019 09:53:25 -0800 (PST) From: =?UTF-8?q?Cl=C3=A9ment=20P=C3=A9ron?= To: Thierry Reding , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Rob Herring , Mark Rutland , Maxime Ripard , Chen-Yu Tsai , Philipp Zabel Cc: linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, Jernej Skrabec , =?UTF-8?q?Cl=C3=A9ment=20P=C3=A9ron?= Subject: [PATCH v7 2/8] pwm: sun4i: Add an optional probe for reset line Date: Tue, 19 Nov 2019 18:53:13 +0100 Message-Id: <20191119175319.16561-3-peron.clem@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191119175319.16561-1-peron.clem@gmail.com> References: <20191119175319.16561-1-peron.clem@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jernej Skrabec H6 PWM core needs deasserted reset line in order to work. Add an optional probe for it. Signed-off-by: Jernej Skrabec Reviewed-by: Uwe Kleine-König Signed-off-by: Clément Péron --- drivers/pwm/pwm-sun4i.c | 33 +++++++++++++++++++++++++++++++-- 1 file changed, 31 insertions(+), 2 deletions(-) diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c index 581d23287333..c17935805690 100644 --- a/drivers/pwm/pwm-sun4i.c +++ b/drivers/pwm/pwm-sun4i.c @@ -16,6 +16,7 @@ #include #include #include +#include #include #include #include @@ -78,6 +79,7 @@ struct sun4i_pwm_data { struct sun4i_pwm_chip { struct pwm_chip chip; struct clk *clk; + struct reset_control *rst; void __iomem *base; spinlock_t ctrl_lock; const struct sun4i_pwm_data *data; @@ -364,6 +366,21 @@ static int sun4i_pwm_probe(struct platform_device *pdev) if (IS_ERR(pwm->clk)) return PTR_ERR(pwm->clk); + pwm->rst = devm_reset_control_get_optional_shared(&pdev->dev, NULL); + if (IS_ERR(pwm->rst)) { + if (PTR_ERR(pwm->rst) != -EPROBE_DEFER) + dev_err(&pdev->dev, "get reset failed %pe\n", + pwm->rst); + return PTR_ERR(pwm->rst); + } + + /* Deassert reset */ + ret = reset_control_deassert(pwm->rst); + if (ret) { + dev_err(&pdev->dev, "Cannot deassert reset control\n"); + return ret; + } + pwm->chip.dev = &pdev->dev; pwm->chip.ops = &sun4i_pwm_ops; pwm->chip.base = -1; @@ -376,19 +393,31 @@ static int sun4i_pwm_probe(struct platform_device *pdev) ret = pwmchip_add(&pwm->chip); if (ret < 0) { dev_err(&pdev->dev, "failed to add PWM chip: %d\n", ret); - return ret; + goto err_pwm_add; } platform_set_drvdata(pdev, pwm); return 0; + +err_pwm_add: + reset_control_assert(pwm->rst); + + return ret; } static int sun4i_pwm_remove(struct platform_device *pdev) { struct sun4i_pwm_chip *pwm = platform_get_drvdata(pdev); + int ret; + + ret = pwmchip_remove(&pwm->chip); + if (ret) + return ret; + + reset_control_assert(pwm->rst); - return pwmchip_remove(&pwm->chip); + return 0; } static struct platform_driver sun4i_pwm_driver = { -- 2.20.1