From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEF34C432C0 for ; Tue, 19 Nov 2019 18:19:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9944D2231E for ; Tue, 19 Nov 2019 18:19:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574187574; bh=Ke5+v8YZHAT8xyxZWhg6SyQsCREdJm9kePCdyBvjixo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=eoXi9YPMoa2cfKYasyyEC73Rk4bSHqYhIkCiAOrBHxtCnFYwJTD0NDCElwdOhYMjh NvZT4jh3ETz8fPL8Gra+JKh2rZnk5sFv/1+RbhzQEBcJnBmyOkltbv/fgdOZ1OVUqP ExKTs47feE15ln4OEKJJiC2DXy2xyIKn9oEHIr2E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727014AbfKSSTd (ORCPT ); Tue, 19 Nov 2019 13:19:33 -0500 Received: from foss.arm.com ([217.140.110.172]:56552 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726510AbfKSSTd (ORCPT ); Tue, 19 Nov 2019 13:19:33 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C8C891FB; Tue, 19 Nov 2019 10:19:32 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3585B3F703; Tue, 19 Nov 2019 10:19:32 -0800 (PST) Date: Tue, 19 Nov 2019 18:19:30 +0000 From: Mark Brown To: Luhua Xu Cc: Matthias Brugger , Allison Randal , Enrico Weigelt , Kate Stewart , Leilk Liu , Thomas Gleixner , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] spi: mediatek: add cs timing configuration support Message-ID: <20191119181930.GF3634@sirena.org.uk> Mail-Followup-To: Luhua Xu , Matthias Brugger , Allison Randal , Enrico Weigelt , Kate Stewart , Leilk Liu , Thomas Gleixner , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org References: <1574053037-26721-1-git-send-email-luhua.xu@mediatek.com> <1574053037-26721-3-git-send-email-luhua.xu@mediatek.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="XIiC+We3v3zHqZ6Z" Content-Disposition: inline In-Reply-To: <1574053037-26721-3-git-send-email-luhua.xu@mediatek.com> X-Cookie: Beam me up, Scotty! It ate my phaser! User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --XIiC+We3v3zHqZ6Z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Nov 18, 2019 at 12:57:17PM +0800, Luhua Xu wrote: > Add configure SPI CS setup/hold/idle delays in terms > of clk count support, and use one period of current > spi speed as default if setup/hold/idle not indicated. We have added a generic way to specify delays like this via the set_cs_timing() operation and related fields in the spi_device struct which operate in terms of spi_delay - Alexandru Ardelean added them recently. This supports both times and clock cycles as units so should fit with what your hardware can do, the interface is new though so there may be soem rough edges to worry about. --XIiC+We3v3zHqZ6Z Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl3UMjEACgkQJNaLcl1U h9DuYQf/Sh6DLOmgyjnIubrb27dh7rENm3ubM+wQws2RYtpLpn81Y+QeCeuFmG+5 qab+os+aGjg82VyLmLMU07NqDkCLfu4JVFUudK3M5ZLCZcQQ0VPhQ2CUSya+gSkr cDrncou8L/Q7E1HlRwY+b3/S1qLxrMGYA5JkaivmCTC/RRhtUDb+6JORzIpVER15 XrgH6cJM79jkEfUWoz5AQITORtrebZnKDsYDxWzbcjLE0SleAK8AJ55zPf1QNzMz qX3dpdyEDPfMWEiCitAOHRNzwpVdBKwOCN5vXJdbPXRJN7DhkDwWigDSaz+9uL0m f8lMvtoliW5cyEX0Q/O+WEvR9vdvjA== =vdlB -----END PGP SIGNATURE----- --XIiC+We3v3zHqZ6Z--