From: Masami Hiramatsu <mhiramat@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Ingo Molnar <mingo@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org,
Tom Zanussi <tom.zanussi@linux.intel.com>,
Ravi Bangoria <ravi.bangoria@linux.ibm.com>,
Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH v3 0/7] perf/probe: Support multiprobe and immediates with fixes
Date: Tue, 19 Nov 2019 22:46:04 +0900 [thread overview]
Message-ID: <20191119224604.1d3665b8e8dfdcfcc2a8f31e@kernel.org> (raw)
In-Reply-To: <20191118221104.GF20465@kernel.org>
On Mon, 18 Nov 2019 19:11:04 -0300
Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Em Mon, Nov 18, 2019 at 05:11:40PM +0900, Masami Hiramatsu escreveu:
> > Hi Arnaldo,
> >
> > This is the 3rd version of the multiprobe support on perf probe
> > including some fixes about "representive lines"
> >
> > The previous thread is here:
> >
> > https://lkml.kernel.org/r/157314406866.4063.16995747442215702109.stgit@devnote2
> >
> > On the previous thread, we discussed some issues about incorrect line
> > information shown by perf probe. I finally fixed those by introducing
> > an idea of "representive line" -- a line which has a unique address
> > (no other lines shares the same address) or a line which has the least
> > line number among lines sharing same address. Now perf probe only shows
> > such representive lines can be probed([1/7][3/7]), and if user tries to
> > probe other non representive lines, it shows which line user should
> > probe ([2/7]). The rest of patches in the series are same as v2 (except
> > for [4/7], example output is updated)
> >
> > This can be applied on top of perf/core.
>
> Thanks, applied everything, only the two last patches I didn't test, the
> kernel in this machine doesn't have the features it needs, we can fix
> things if some problem lurks there.
Thank you Arnaldo! OK, if anything happens, I'll fix it soon.
Best Regards,
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2019-11-19 13:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-18 8:11 [PATCH v3 0/7] perf/probe: Support multiprobe and immediates with fixes Masami Hiramatsu
2019-11-18 8:11 ` [PATCH v3 1/7] perf probe: Show correct statement line number by perf probe -l Masami Hiramatsu
2019-11-18 21:57 ` Arnaldo Carvalho de Melo
2019-11-19 16:56 ` [tip: perf/core] " tip-bot2 for Masami Hiramatsu
2019-11-18 8:12 ` [PATCH v3 2/7] perf probe: Verify given line is a representive line Masami Hiramatsu
2019-11-18 21:59 ` Arnaldo Carvalho de Melo
2019-11-19 16:56 ` [tip: perf/core] " tip-bot2 for Masami Hiramatsu
2019-11-18 8:12 ` [PATCH v3 3/7] perf probe: Do not show non representive lines by perf-probe -L Masami Hiramatsu
2019-11-18 22:01 ` Arnaldo Carvalho de Melo
2019-11-19 16:56 ` [tip: perf/core] " tip-bot2 for Masami Hiramatsu
2019-11-18 8:12 ` [PATCH v3 4/7] perf probe: Generate event name with line number Masami Hiramatsu
2019-11-18 22:03 ` Arnaldo Carvalho de Melo
2019-11-19 16:56 ` [tip: perf/core] " tip-bot2 for Masami Hiramatsu
2019-11-18 8:12 ` [PATCH v3 5/7] perf probe: Support multiprobe event Masami Hiramatsu
2019-11-19 16:56 ` [tip: perf/core] " tip-bot2 for Masami Hiramatsu
2019-11-18 8:12 ` [PATCH v3 6/7] perf probe: Support DW_AT_const_value constant value Masami Hiramatsu
2019-11-19 16:56 ` [tip: perf/core] " tip-bot2 for Masami Hiramatsu
2019-11-18 8:12 ` [PATCH v3 7/7] perf probe: Trace a magic number if variable is not found Masami Hiramatsu
2019-11-19 16:56 ` [tip: perf/core] " tip-bot2 for Masami Hiramatsu
2019-11-18 22:11 ` [PATCH v3 0/7] perf/probe: Support multiprobe and immediates with fixes Arnaldo Carvalho de Melo
2019-11-19 13:46 ` Masami Hiramatsu [this message]
2019-11-19 14:33 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191119224604.1d3665b8e8dfdcfcc2a8f31e@kernel.org \
--to=mhiramat@kernel.org \
--cc=acme@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=ravi.bangoria@linux.ibm.com \
--cc=rostedt@goodmis.org \
--cc=tom.zanussi@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).