From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C417C43215 for ; Wed, 20 Nov 2019 10:52:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E4EDC22440 for ; Wed, 20 Nov 2019 10:52:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728901AbfKTKwc (ORCPT ); Wed, 20 Nov 2019 05:52:32 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:37550 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727514AbfKTKwb (ORCPT ); Wed, 20 Nov 2019 05:52:31 -0500 Received: from [79.140.122.151] (helo=wittgenstein) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1iXNb3-0004ZQ-Vn; Wed, 20 Nov 2019 10:52:30 +0000 Date: Wed, 20 Nov 2019 11:52:29 +0100 From: Christian Brauner To: Luc Van Oostenryck Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Joel Fernandes , Christian Brauner Subject: Re: [PATCH v2] fork: fix pidfd_poll()'s return type Message-ID: <20191120105227.uln6z5d67ita3edj@wittgenstein> References: <20191120002145.skgtkx2f5dxagx4f@wittgenstein> <20191120003320.31138-1-luc.vanoostenryck@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191120003320.31138-1-luc.vanoostenryck@gmail.com> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 20, 2019 at 01:33:20AM +0100, Luc Van Oostenryck wrote: > pidfd_poll() is defined as returning 'unsigned int' but the > .poll method is declared as returning '__poll_t', a bitwise type. > > Fix this by using the proper return type and using the EPOLL > constants instead of the POLL ones, as required for __poll_t. > > Fixes: b53b0b9d9a61 ("pidfd: add polling support") > Cc: Joel Fernandes (Google) > Cc: Christian Brauner > Cc: stable@vger.kernel.org # 5.3 > Signed-off-by: Luc Van Oostenryck > Reviewed-by: Christian Brauner Applied to https://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux.git/log/?h=fixes Will likely send this as a fix for v5.4 still so stable only has to backport this to 5.3 and not 5.4 too. Thanks! Christian