linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm/komeda: Remove unnecessary komeda_wb_connector_detect
@ 2019-11-20 12:03 Mihail Atanassov
  2019-11-21  6:33 ` james qian wang (Arm Technology China)
  0 siblings, 1 reply; 2+ messages in thread
From: Mihail Atanassov @ 2019-11-20 12:03 UTC (permalink / raw)
  To: dri-devel
  Cc: Mihail Atanassov, nd, Maarten Lankhorst, Maxime Ripard,
	Sean Paul, james qian wang (Arm Technology China),
	Liviu Dudau, Brian Starkey, David Airlie, Daniel Vetter,
	linux-kernel

The func is optional and the connector will report as always connected,
i.e. no change in behaviour.

Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
---
 drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
index e465cc4879c9..c89ecdba8c28 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
@@ -107,12 +107,6 @@ static const struct drm_connector_helper_funcs komeda_wb_conn_helper_funcs = {
 	.mode_valid	= komeda_wb_connector_mode_valid,
 };
 
-static enum drm_connector_status
-komeda_wb_connector_detect(struct drm_connector *connector, bool force)
-{
-	return connector_status_connected;
-}
-
 static int
 komeda_wb_connector_fill_modes(struct drm_connector *connector,
 			       uint32_t maxX, uint32_t maxY)
@@ -128,7 +122,6 @@ static void komeda_wb_connector_destroy(struct drm_connector *connector)
 
 static const struct drm_connector_funcs komeda_wb_connector_funcs = {
 	.reset			= drm_atomic_helper_connector_reset,
-	.detect			= komeda_wb_connector_detect,
 	.fill_modes		= komeda_wb_connector_fill_modes,
 	.destroy		= komeda_wb_connector_destroy,
 	.atomic_duplicate_state	= drm_atomic_helper_connector_duplicate_state,
-- 
2.23.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: drm/komeda: Remove unnecessary komeda_wb_connector_detect
  2019-11-20 12:03 [PATCH] drm/komeda: Remove unnecessary komeda_wb_connector_detect Mihail Atanassov
@ 2019-11-21  6:33 ` james qian wang (Arm Technology China)
  0 siblings, 0 replies; 2+ messages in thread
From: james qian wang (Arm Technology China) @ 2019-11-21  6:33 UTC (permalink / raw)
  To: Mihail Atanassov
  Cc: dri-devel, David Airlie, Liviu Dudau, linux-kernel, nd, Sean Paul

On Wed, Nov 20, 2019 at 12:03:55PM +0000, Mihail Atanassov wrote:
> The func is optional and the connector will report as always connected,
> i.e. no change in behaviour.
> 
> Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
> ---
>  drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
> index e465cc4879c9..c89ecdba8c28 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
> @@ -107,12 +107,6 @@ static const struct drm_connector_helper_funcs komeda_wb_conn_helper_funcs = {
>  	.mode_valid	= komeda_wb_connector_mode_valid,
>  };
>  
> -static enum drm_connector_status
> -komeda_wb_connector_detect(struct drm_connector *connector, bool force)
> -{
> -	return connector_status_connected;
> -}
> -
>  static int
>  komeda_wb_connector_fill_modes(struct drm_connector *connector,
>  			       uint32_t maxX, uint32_t maxY)
> @@ -128,7 +122,6 @@ static void komeda_wb_connector_destroy(struct drm_connector *connector)
>  
>  static const struct drm_connector_funcs komeda_wb_connector_funcs = {
>  	.reset			= drm_atomic_helper_connector_reset,
> -	.detect			= komeda_wb_connector_detect,
>  	.fill_modes		= komeda_wb_connector_fill_modes,
>  	.destroy		= komeda_wb_connector_destroy,
>  	.atomic_duplicate_state	= drm_atomic_helper_connector_duplicate_state,

Looks good to me.

Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-11-21  6:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-20 12:03 [PATCH] drm/komeda: Remove unnecessary komeda_wb_connector_detect Mihail Atanassov
2019-11-21  6:33 ` james qian wang (Arm Technology China)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).