From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88010C432C0 for ; Wed, 20 Nov 2019 14:36:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6565F21823 for ; Wed, 20 Nov 2019 14:36:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731679AbfKTOgZ (ORCPT ); Wed, 20 Nov 2019 09:36:25 -0500 Received: from xavier.telenet-ops.be ([195.130.132.52]:48510 "EHLO xavier.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729591AbfKTOgY (ORCPT ); Wed, 20 Nov 2019 09:36:24 -0500 Received: from ramsan ([84.195.182.253]) by xavier.telenet-ops.be with bizsmtp id UEcN2100S5USYZQ01EcNRk; Wed, 20 Nov 2019 15:36:23 +0100 Received: from rox.of.borg ([192.168.97.57]) by ramsan with esmtp (Exim 4.90_1) (envelope-from ) id 1iXR5i-00020x-MS; Wed, 20 Nov 2019 15:36:22 +0100 Received: from geert by rox.of.borg with local (Exim 4.90_1) (envelope-from ) id 1iXR5i-0000He-LR; Wed, 20 Nov 2019 15:36:22 +0100 From: Geert Uytterhoeven To: Greg Kroah-Hartman , "Rafael J . Wysocki" Cc: linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH 2/2] driver core: Print device in really_probe() warning backtrace Date: Wed, 20 Nov 2019 15:36:19 +0100 Message-Id: <20191120143619.1027-3-geert+renesas@glider.be> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191120143619.1027-1-geert+renesas@glider.be> References: <20191120143619.1027-1-geert+renesas@glider.be> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If a device already has devres items attached before probing, a warning backtrace is printed. However, this backtrace does not reveal the offending device, leaving the user uninformed. Use dev_WARN_ON() instead of WARN_ON() to fix this. Signed-off-by: Geert Uytterhoeven --- drivers/base/dd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/dd.c b/drivers/base/dd.c index d811e60610d33ae9..a7e8040ef0003f44 100644 --- a/drivers/base/dd.c +++ b/drivers/base/dd.c @@ -516,7 +516,7 @@ static int really_probe(struct device *dev, struct device_driver *drv) atomic_inc(&probe_count); pr_debug("bus: '%s': %s: probing driver %s with device %s\n", drv->bus->name, __func__, drv->name, dev_name(dev)); - WARN_ON(!list_empty(&dev->devres_head)); + dev_WARN_ON(dev, !list_empty(&dev->devres_head)); re_probe: dev->driver = drv; -- 2.17.1