linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org,
	Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH v7 10/12] perf stat: Use affinity for reading
Date: Wed, 20 Nov 2019 16:12:23 +0100	[thread overview]
Message-ID: <20191120151223.GF4007@krava> (raw)
In-Reply-To: <20191116055229.62002-11-andi@firstfloor.org>

On Fri, Nov 15, 2019 at 09:52:27PM -0800, Andi Kleen wrote:

SNIP

> +					perf_evsel__name(counter),
> +					cpu,
> +					count->val, count->ena, count->run);
> +		}
>  	}
>  
>  	return 0;
> @@ -325,15 +318,36 @@ static int read_counter(struct evsel *counter, struct timespec *rs)
>  static void read_counters(struct timespec *rs)
>  {
>  	struct evsel *counter;
> -	int ret;
> +	struct affinity affinity;
> +	int i, ncpus, cpu;
> +
> +	if (affinity__setup(&affinity) < 0)
> +		return;
> +
> +	ncpus = evsel_list->core.all_cpus->nr;

please use perf_cpu_map__nr

> +	if (!target__has_cpu(&target) || target__has_per_thread(&target))
> +		ncpus = 1;
> +	evlist__for_each_cpu (evsel_list, i, cpu) {
> +		if (i >= ncpus)
> +			break;
> +		affinity__set(&affinity, cpu);
> +
> +		evlist__for_each_entry(evsel_list, counter) {
> +			if (evsel__cpu_iter_skip(counter, cpu))
> +				continue;
> +			if (!counter->err)
> +				counter->err = read_counter_cpu(counter, rs,
> +								counter->cpu_iter - 1);

please use { } to enclose multiline if legs

thanks,
jirka


  reply	other threads:[~2019-11-20 15:12 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-16  5:52 Optimize perf stat for large number of events/cpus Andi Kleen
2019-11-16  5:52 ` [PATCH v7 01/12] perf pmu: Use file system cache to optimize sysfs access Andi Kleen
2019-11-16  5:52 ` [PATCH v7 02/12] perf affinity: Add infrastructure to save/restore affinity Andi Kleen
2019-11-16  5:52 ` [PATCH v7 03/12] perf cpumap: Maintain cpumaps ordered and without dups Andi Kleen
2019-11-16  5:52 ` [PATCH v7 04/12] perf evlist: Maintain evlist->all_cpus Andi Kleen
2019-11-16  5:52 ` [PATCH v7 05/12] perf evsel: Add iterator to iterate over events ordered by CPU Andi Kleen
2019-11-16  5:52 ` [PATCH v7 06/12] perf evsel: Add functions to close evsel on a CPU Andi Kleen
2019-11-16  5:52 ` [PATCH v7 07/12] perf stat: Use affinity for closing file descriptors Andi Kleen
2019-11-16  5:52 ` [PATCH v7 08/12] perf stat: Factor out open error handling Andi Kleen
2019-11-16  5:52 ` [PATCH v7 09/12] perf stat: Use affinity for opening events Andi Kleen
2019-11-20 15:07   ` Jiri Olsa
2019-11-20 22:31     ` Andi Kleen
2019-11-21 15:13       ` Jiri Olsa
2019-11-16  5:52 ` [PATCH v7 10/12] perf stat: Use affinity for reading Andi Kleen
2019-11-20 15:12   ` Jiri Olsa [this message]
2019-11-16  5:52 ` [PATCH v7 11/12] perf evsel: Add functions to enable/disable for a specific CPU Andi Kleen
2019-11-16  5:52 ` [PATCH v7 12/12] perf stat: Use affinity for enabling/disabling events Andi Kleen
2019-11-20 15:16 ` Optimize perf stat for large number of events/cpus Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191120151223.GF4007@krava \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH v7 10/12] perf stat: Use affinity for reading' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).