linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.com>, Rob Herring <robh@kernel.org>,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH 2/2] tty: add retry to tty_init_dev() to workaround a race condition
Date: Wed, 20 Nov 2019 15:55:08 +0000	[thread overview]
Message-ID: <20191120155508.kt4prkqmdd4qwioh@debian> (raw)
In-Reply-To: <20191120154450.GB3004157@kroah.com>

On Wed, Nov 20, 2019 at 04:44:50PM +0100, Greg Kroah-Hartman wrote:
> On Wed, Nov 20, 2019 at 03:17:09PM +0000, Sudip Mukherjee wrote:
> > There seems to be a race condition in tty drivers and I could see on
> > many boot cycles a NULL pointer dereference as tty_init_dev() tries to
> > do 'tty->port->itty = tty' even though tty->port is NULL.
<snip>
> > +++ b/drivers/tty/pty.c
> > @@ -842,7 +842,7 @@ static int ptmx_open(struct inode *inode, struct file *filp)
> >  
> >  
> >  	mutex_lock(&tty_mutex);
> > -	tty = tty_init_dev(ptm_driver, index);
> > +	tty = tty_init_dev(ptm_driver, index, 0);
> 
> Horrible naming scheme for this new "flag".
> 
> Look at that call here, can you instantly tell what this call is doing
> with "0"?  I sure can not :(

well, I also made the mistake of 1->0 in my initial patch. :(

> 
> If you really want to do this, you make a different function,
> tty_init_dev_retry() and then have that pass in a retry flag in the tty
> core, so that any users always know what they are doing here.

will do.

> 
> But, this really feels like a race in the code somewhere:
> 
> > --- a/drivers/tty/tty_io.c
> > +++ b/drivers/tty/tty_io.c
> > @@ -1295,6 +1295,7 @@ static int tty_reopen(struct tty_struct *tty)
> >   *	tty_init_dev		-	initialise a tty device
> >   *	@driver: tty driver we are opening a device on
> >   *	@idx: device index
> > + *	@retry: retry count if driver has not set tty->port yet
> 
> Why would tty->port not be set up already?  The caller has control over
> this, what is not happening correctly to cause this?

Will add more debugs to check what is happening now and then send you v2.


--
Regards
Sudip

  reply	other threads:[~2019-11-20 15:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-20 15:17 [PATCH 1/2] tty: remove unused argument from tty_open_by_driver() Sudip Mukherjee
2019-11-20 15:17 ` [PATCH 2/2] tty: add retry to tty_init_dev() to workaround a race condition Sudip Mukherjee
2019-11-20 15:44   ` Greg Kroah-Hartman
2019-11-20 15:55     ` Sudip Mukherjee [this message]
2019-11-25  6:27   ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191120155508.kt4prkqmdd4qwioh@debian \
    --to=sudipm.mukherjee@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).