From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
Rob Herring <robh@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Andrew Murray <andrew.murray@arm.com>,
Srinath Mannam <srinath.mannam@broadcom.com>,
Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
Marek Vasut <marek.vasut+renesas@gmail.com>,
linux-pci@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: of: Restore alignment/indentation in host bridge window table
Date: Wed, 20 Nov 2019 16:27:50 +0000 [thread overview]
Message-ID: <20191120162750.GA3279@e121166-lin.cambridge.arm.com> (raw)
In-Reply-To: <20191119191505.25286-1-geert+renesas@glider.be>
On Tue, Nov 19, 2019 at 08:15:05PM +0100, Geert Uytterhoeven wrote:
> Since the printing of the inbound resources was added, alignment and
> indentation of the host bridge window table is broken because of two
> reasons:
> 1. The "IB MEM" row header is longer than the other headers,
> 2. Inbound ranges typically extend beyond 32-bit address space, and thus
> don't fit in "#010llx".
>
> Fix this by extending the row header field to 6 characters, and the
> format string to 40-bit addresses.
>
> Use "%6s" to handle field size and right-alignment, instead of manual
> preparation using error-prone snprintf() calls. Use the exact same
> format string for both cases, to allow sharing.
>
> Impact on kernel boot log on r8a7791/koelsch:
>
> rcar-pcie fe000000.pcie: host bridge /soc/pcie@fe000000 ranges:
> -rcar-pcie fe000000.pcie: IO 0xfe100000..0xfe1fffff -> 0x00000000
> -rcar-pcie fe000000.pcie: MEM 0xfe200000..0xfe3fffff -> 0xfe200000
> -rcar-pcie fe000000.pcie: MEM 0x30000000..0x37ffffff -> 0x30000000
> -rcar-pcie fe000000.pcie: MEM 0x38000000..0x3fffffff -> 0x38000000
> -rcar-pcie fe000000.pcie: IB MEM 0x40000000..0xbfffffff -> 0x40000000
> -rcar-pcie fe000000.pcie: IB MEM 0x200000000..0x2ffffffff -> 0x200000000
> +rcar-pcie fe000000.pcie: IO 0x00fe100000..0x00fe1fffff -> 0x0000000000
> +rcar-pcie fe000000.pcie: MEM 0x00fe200000..0x00fe3fffff -> 0x00fe200000
> +rcar-pcie fe000000.pcie: MEM 0x0030000000..0x0037ffffff -> 0x0030000000
> +rcar-pcie fe000000.pcie: MEM 0x0038000000..0x003fffffff -> 0x0038000000
> +rcar-pcie fe000000.pcie: IB MEM 0x0040000000..0x00bfffffff -> 0x0040000000
> +rcar-pcie fe000000.pcie: IB MEM 0x0200000000..0x02ffffffff -> 0x0200000000
>
> Fixes: 52ac576f88f9f701 ("PCI: of: Add inbound resource parsing to helpers")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/pci/of.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
Hi Rob,
do you mind if I squash this patch in the Fixes: above ?
Thanks,
Lorenzo
> diff --git a/drivers/pci/of.c b/drivers/pci/of.c
> index e7e12adcff3a3836..81ceeaa6f1d5a2c5 100644
> --- a/drivers/pci/of.c
> +++ b/drivers/pci/of.c
> @@ -265,7 +265,7 @@ static int devm_of_pci_get_host_bridge_resources(struct device *dev,
> struct resource *bus_range;
> struct of_pci_range range;
> struct of_pci_range_parser parser;
> - char range_type[4];
> + const char *range_type;
> int err;
>
> if (io_base)
> @@ -299,12 +299,12 @@ static int devm_of_pci_get_host_bridge_resources(struct device *dev,
> for_each_of_pci_range(&parser, &range) {
> /* Read next ranges element */
> if ((range.flags & IORESOURCE_TYPE_BITS) == IORESOURCE_IO)
> - snprintf(range_type, 4, " IO");
> + range_type = "IO";
> else if ((range.flags & IORESOURCE_TYPE_BITS) == IORESOURCE_MEM)
> - snprintf(range_type, 4, "MEM");
> + range_type = "MEM";
> else
> - snprintf(range_type, 4, "err");
> - dev_info(dev, " %s %#010llx..%#010llx -> %#010llx\n",
> + range_type = "err";
> + dev_info(dev, " %6s %#012llx..%#012llx -> %#012llx\n",
> range_type, range.cpu_addr,
> range.cpu_addr + range.size - 1, range.pci_addr);
>
> @@ -359,8 +359,8 @@ static int devm_of_pci_get_host_bridge_resources(struct device *dev,
> range.cpu_addr == OF_BAD_ADDR || range.size == 0)
> continue;
>
> - dev_info(dev, "IB MEM %#010llx..%#010llx -> %#010llx\n",
> - range.cpu_addr,
> + dev_info(dev, " %6s %#012llx..%#012llx -> %#012llx\n",
> + "IB MEM", range.cpu_addr,
> range.cpu_addr + range.size - 1, range.pci_addr);
>
>
> --
> 2.17.1
>
next prev parent reply other threads:[~2019-11-20 16:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 19:15 [PATCH] PCI: of: Restore alignment/indentation in host bridge window table Geert Uytterhoeven
2019-11-19 19:48 ` Bjorn Helgaas
2019-11-20 8:49 ` Geert Uytterhoeven
2019-11-20 16:27 ` Lorenzo Pieralisi [this message]
2019-11-20 16:45 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191120162750.GA3279@e121166-lin.cambridge.arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=andrew.murray@arm.com \
--cc=bhelgaas@google.com \
--cc=geert+renesas@glider.be \
--cc=gustavo.pimentel@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=robh@kernel.org \
--cc=srinath.mannam@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).