* [PATCH][next] drm/amd/display: fix double assignment to msg_id field
@ 2019-11-20 17:22 Colin King
2019-11-27 16:51 ` Harry Wentland
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2019-11-20 17:22 UTC (permalink / raw)
To: Harry Wentland, Leo Li, Alex Deucher, Christian König,
David Zhou, David Airlie, Daniel Vetter, Bhawanpreet Lakha,
amd-gfx, dri-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The msg_id field is being assigned twice. Fix this by replacing the second
assignment with an assignment to msg_size.
Addresses-Coverity: ("Unused value")
Fixes: 11a00965d261 ("drm/amd/display: Add PSP block to verify HDCP2.2 steps")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c
index 2dd5feec8e6c..6791c5844e43 100644
--- a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c
+++ b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c
@@ -42,7 +42,7 @@ static void hdcp2_message_init(struct mod_hdcp *hdcp,
in->process.msg2_desc.msg_id = TA_HDCP_HDCP2_MSG_ID__NULL_MESSAGE;
in->process.msg2_desc.msg_size = 0;
in->process.msg3_desc.msg_id = TA_HDCP_HDCP2_MSG_ID__NULL_MESSAGE;
- in->process.msg3_desc.msg_id = 0;
+ in->process.msg3_desc.msg_size = 0;
}
enum mod_hdcp_status mod_hdcp_remove_display_topology(struct mod_hdcp *hdcp)
{
--
2.24.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH][next] drm/amd/display: fix double assignment to msg_id field
2019-11-20 17:22 [PATCH][next] drm/amd/display: fix double assignment to msg_id field Colin King
@ 2019-11-27 16:51 ` Harry Wentland
2019-12-02 21:25 ` Alex Deucher
0 siblings, 1 reply; 3+ messages in thread
From: Harry Wentland @ 2019-11-27 16:51 UTC (permalink / raw)
To: Colin King, Harry Wentland, Leo Li, Alex Deucher,
Christian König, David Zhou, David Airlie, Daniel Vetter,
Bhawanpreet Lakha, amd-gfx, dri-devel
Cc: kernel-janitors, linux-kernel
On 2019-11-20 12:22 p.m., Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The msg_id field is being assigned twice. Fix this by replacing the second
> assignment with an assignment to msg_size.
>
> Addresses-Coverity: ("Unused value")
> Fixes: 11a00965d261 ("drm/amd/display: Add PSP block to verify HDCP2.2 steps")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Harry Wentland <harry.wentland>
Harry
> ---
> drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c
> index 2dd5feec8e6c..6791c5844e43 100644
> --- a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c
> +++ b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c
> @@ -42,7 +42,7 @@ static void hdcp2_message_init(struct mod_hdcp *hdcp,
> in->process.msg2_desc.msg_id = TA_HDCP_HDCP2_MSG_ID__NULL_MESSAGE;
> in->process.msg2_desc.msg_size = 0;
> in->process.msg3_desc.msg_id = TA_HDCP_HDCP2_MSG_ID__NULL_MESSAGE;
> - in->process.msg3_desc.msg_id = 0;
> + in->process.msg3_desc.msg_size = 0;
> }
> enum mod_hdcp_status mod_hdcp_remove_display_topology(struct mod_hdcp *hdcp)
> {
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][next] drm/amd/display: fix double assignment to msg_id field
2019-11-27 16:51 ` Harry Wentland
@ 2019-12-02 21:25 ` Alex Deucher
0 siblings, 0 replies; 3+ messages in thread
From: Alex Deucher @ 2019-12-02 21:25 UTC (permalink / raw)
To: Harry Wentland
Cc: Colin King, Harry Wentland, Leo Li, Alex Deucher,
Christian König, David Zhou, David Airlie, Daniel Vetter,
Bhawanpreet Lakha, amd-gfx list, Maling list - DRI developers,
kernel-janitors, LKML
Applied. thanks!
Alex
On Wed, Nov 27, 2019 at 11:51 AM Harry Wentland <hwentlan@amd.com> wrote:
>
> On 2019-11-20 12:22 p.m., Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > The msg_id field is being assigned twice. Fix this by replacing the second
> > assignment with an assignment to msg_size.
> >
> > Addresses-Coverity: ("Unused value")
> > Fixes: 11a00965d261 ("drm/amd/display: Add PSP block to verify HDCP2.2 steps")
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Reviewed-by: Harry Wentland <harry.wentland>
>
> Harry
>
> > ---
> > drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c
> > index 2dd5feec8e6c..6791c5844e43 100644
> > --- a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c
> > +++ b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c
> > @@ -42,7 +42,7 @@ static void hdcp2_message_init(struct mod_hdcp *hdcp,
> > in->process.msg2_desc.msg_id = TA_HDCP_HDCP2_MSG_ID__NULL_MESSAGE;
> > in->process.msg2_desc.msg_size = 0;
> > in->process.msg3_desc.msg_id = TA_HDCP_HDCP2_MSG_ID__NULL_MESSAGE;
> > - in->process.msg3_desc.msg_id = 0;
> > + in->process.msg3_desc.msg_size = 0;
> > }
> > enum mod_hdcp_status mod_hdcp_remove_display_topology(struct mod_hdcp *hdcp)
> > {
> >
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-12-02 21:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-20 17:22 [PATCH][next] drm/amd/display: fix double assignment to msg_id field Colin King
2019-11-27 16:51 ` Harry Wentland
2019-12-02 21:25 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).