From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B72E3C432C3 for ; Wed, 20 Nov 2019 17:48:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 928762080F for ; Wed, 20 Nov 2019 17:48:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="ddWR/VPt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727972AbfKTRsU (ORCPT ); Wed, 20 Nov 2019 12:48:20 -0500 Received: from mail.skyhub.de ([5.9.137.197]:35402 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727671AbfKTRsT (ORCPT ); Wed, 20 Nov 2019 12:48:19 -0500 Received: from zn.tnic (p200300EC2F0D8C00F553B94F3FB99B80.dip0.t-ipconnect.de [IPv6:2003:ec:2f0d:8c00:f553:b94f:3fb9:9b80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 4B7D41EC0C0A; Wed, 20 Nov 2019 18:48:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1574272097; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=sRGk1TFOicxI4LhR8Ex8diUi+6oCm1GfPkLIX+2fv3k=; b=ddWR/VPtrKLvTOJFzaHVDWgpMgbnK9t9PGNQfhYFWQXJDrF/b/wgn4TGqzrtqDphOUfvY9 S9/TKirB/KIQWRegfs5f8xqqEspKeinJ7gj3veo+LbHfNO/22QCW/xAe4av/1pQJKREgFD tSdQHBcSqiKfr3ZQdsucmfmj3+xUGag= Date: Wed, 20 Nov 2019 18:48:10 +0100 From: Borislav Petkov To: Sean Christopherson Cc: Thomas Gleixner , Ingo Molnar , x86@kernel.org, "H. Peter Anvin" , Peter Zijlstra , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Tony Luck , Tony W Wang-oc , Shuah Khan , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-edac@vger.kernel.org, linux-kselftest@vger.kernel.org, Jarkko Sakkinen Subject: Re: [PATCH v3 01/19] x86/msr-index: Clean up bit defines for IA32_FEATURE_CONTROL MSR Message-ID: <20191120174810.GI2634@zn.tnic> References: <20191119031240.7779-1-sean.j.christopherson@intel.com> <20191119031240.7779-2-sean.j.christopherson@intel.com> <20191119111445.GB27787@zn.tnic> <20191119231822.GA6855@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191119231822.GA6855@linux.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 19, 2019 at 03:18:22PM -0800, Sean Christopherson wrote: > Ugh. Match the SDM unless it's obviously "wrong"? :-) It might literally > be the only instance of the SDM using "on" instead of "enable(d)" for an > MSR or CR bit. The SDM even refers to it as an enable bit, e.g. "platform > software has not enabled LMCE by setting IA32_FEATURE_CONTROL.LMCE_ON (bit 20)". > > Whining aside, I'm ok going with LMCE_ON, I have a feeling "on" was > deliberately chosen differentiate it from IA32_MCG_EXT_CTL.LMCE_EN. Nah, ok, let's leave this as a one-off case where the SDM is simply wrong but otherwise the bit names are correct and we keep them the same as in the SDM to avoid obvious confusion. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette