From: Yang Weijiang <weijiang.yang@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Yang Weijiang <weijiang.yang@intel.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
jmattson@google.com, sean.j.christopherson@intel.com,
yu.c.zhang@linux.intel.com, alazar@bitdefender.com,
edwin.zhai@intel.com
Subject: Re: [PATCH v7 2/9] vmx: spp: Add control flags for Sub-Page Protection(SPP)
Date: Thu, 21 Nov 2019 23:34:42 +0800 [thread overview]
Message-ID: <20191121153442.GH17169@local-michael-cet-test> (raw)
In-Reply-To: <d6e71e7b-b708-211c-24b7-8ffe03a52842@redhat.com>
On Thu, Nov 21, 2019 at 11:04:51AM +0100, Paolo Bonzini wrote:
> On 19/11/19 09:49, Yang Weijiang wrote:
> > @@ -228,6 +228,7 @@
> > #define X86_FEATURE_FLEXPRIORITY ( 8*32+ 2) /* Intel FlexPriority */
> > #define X86_FEATURE_EPT ( 8*32+ 3) /* Intel Extended Page Table */
> > #define X86_FEATURE_VPID ( 8*32+ 4) /* Intel Virtual Processor ID */
> > +#define X86_FEATURE_SPP ( 8*32+ 5) /* Intel EPT-based Sub-Page Write Protection */
>
> Please do not include X86_FEATURE_SPP. In general I don't like the VMX
> features word, but apart from that SPP is not a feature that affects all
> VMs in the same way as EPT or FlexPriority.
>
So what's a friendly way to let a user check if SPP feature is there?
> Paolo
next prev parent reply other threads:[~2019-11-21 15:32 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 8:49 [PATCH v7 0/9] Enable Sub-Page Write Protection Support Yang Weijiang
2019-11-19 8:49 ` [PATCH v7 1/9] Documentation: Introduce EPT based Subpage Protection and related ioctls Yang Weijiang
2019-11-21 10:02 ` Paolo Bonzini
2019-11-22 16:17 ` Yang Weijiang
2019-11-19 8:49 ` [PATCH v7 2/9] vmx: spp: Add control flags for Sub-Page Protection(SPP) Yang Weijiang
2019-11-21 10:04 ` Paolo Bonzini
2019-11-21 15:34 ` Yang Weijiang [this message]
2019-11-21 16:02 ` Paolo Bonzini
2019-11-22 15:23 ` Yang Weijiang
2019-11-22 15:55 ` Paolo Bonzini
2019-11-22 16:24 ` Yang Weijiang
2019-11-19 8:49 ` [PATCH v7 3/9] mmu: spp: Add SPP Table setup functions Yang Weijiang
2019-11-21 10:32 ` Paolo Bonzini
2019-11-21 14:57 ` Yang Weijiang
2019-11-21 10:38 ` Paolo Bonzini
2019-11-21 14:55 ` Yang Weijiang
2019-11-19 8:49 ` [PATCH v7 4/9] mmu: spp: Add functions to create/destroy SPP bitmap block Yang Weijiang
2019-11-21 10:43 ` Paolo Bonzini
2019-11-21 14:45 ` Yang Weijiang
2019-11-19 8:49 ` [PATCH v7 5/9] x86: spp: Introduce user-space SPP IOCTLs Yang Weijiang
2019-11-21 10:03 ` Paolo Bonzini
2019-11-22 16:20 ` Yang Weijiang
2019-11-19 8:49 ` [PATCH v7 6/9] vmx: spp: Set up SPP paging table at vmentry/vmexit Yang Weijiang
2019-11-21 10:18 ` Paolo Bonzini
2019-11-21 15:22 ` Yang Weijiang
2019-11-21 16:08 ` Paolo Bonzini
2019-11-22 15:25 ` Yang Weijiang
2019-11-21 10:32 ` Paolo Bonzini
2019-11-21 15:04 ` Yang Weijiang
2019-11-19 8:49 ` [PATCH v7 7/9] mmu: spp: Enable Lazy mode SPP protection Yang Weijiang
2019-11-19 8:49 ` [PATCH v7 8/9] mmu: spp: Handle SPP protected pages when VM memory changes Yang Weijiang
2019-11-21 10:32 ` Paolo Bonzini
2019-11-21 15:01 ` Yang Weijiang
2019-11-19 8:49 ` [PATCH v7 9/9] x86: spp: Add SPP protection check in emulation Yang Weijiang
2019-11-21 10:43 ` [PATCH v7 0/9] Enable Sub-Page Write Protection Support Paolo Bonzini
2019-11-21 14:36 ` Yang Weijiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191121153442.GH17169@local-michael-cet-test \
--to=weijiang.yang@intel.com \
--cc=alazar@bitdefender.com \
--cc=edwin.zhai@intel.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=yu.c.zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).