From: Stefan Hajnoczi <stefanha@redhat.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: virtio-fs@redhat.com, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, dgilbert@redhat.com,
miklos@szeredi.hu
Subject: Re: [PATCH 2/4] virtiofs: Add an index to keep track of first request queue
Date: Thu, 21 Nov 2019 16:00:01 +0000 [thread overview]
Message-ID: <20191121160001.GC445244@stefanha-x1.localdomain> (raw)
In-Reply-To: <20191115205705.2046-3-vgoyal@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 235 bytes --]
On Fri, Nov 15, 2019 at 03:57:03PM -0500, Vivek Goyal wrote:
> @@ -1004,6 +1008,7 @@ __releases(fiq->lock)
> spin_unlock(&fiq->lock);
>
> fs = fiq->priv;
> + queue_id = fs->first_reqq_idx;
The TODO should be moved here.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-11-21 16:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 20:57 [PATCH 0/4] [RFC] virtiofs: Add a notification queue Vivek Goyal
2019-11-15 20:57 ` [PATCH 1/4] virtiofs: Provide a helper function for virtqueue initialization Vivek Goyal
2019-11-15 20:57 ` [PATCH 2/4] virtiofs: Add an index to keep track of first request queue Vivek Goyal
2019-11-21 16:00 ` Stefan Hajnoczi [this message]
2019-11-21 16:00 ` Stefan Hajnoczi
2019-11-15 20:57 ` [PATCH 3/4] virtiofs: Add a virtqueue for notifications Vivek Goyal
2019-11-15 20:57 ` [PATCH 4/4] virtiofs: Support blocking posix locks (fcntl(F_SETLKW)) Vivek Goyal
2019-11-21 17:00 ` Stefan Hajnoczi
2019-11-22 13:00 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191121160001.GC445244@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=dgilbert@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=vgoyal@redhat.com \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).