From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C326C43215 for ; Thu, 21 Nov 2019 20:16:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2458A2068F for ; Thu, 21 Nov 2019 20:16:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727097AbfKUUQg (ORCPT ); Thu, 21 Nov 2019 15:16:36 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:45956 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726293AbfKUUQg (ORCPT ); Thu, 21 Nov 2019 15:16:36 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 3697C1C1BCE; Thu, 21 Nov 2019 21:16:34 +0100 (CET) Date: Thu, 21 Nov 2019 21:16:18 +0100 From: Pavel Machek To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Florian Westphal , Pablo Neira Ayuso , Sasha Levin Subject: Re: [PATCH 4.19 233/422] netfilter: nf_tables: avoid BUG_ON usage Message-ID: <20191121201618.GB15106@duo.ucw.cz> References: <20191119051400.261610025@linuxfoundation.org> <20191119051414.205983228@linuxfoundation.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="cvVnyQ+4j833TQvp" Content-Disposition: inline In-Reply-To: <20191119051414.205983228@linuxfoundation.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --cvVnyQ+4j833TQvp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > From: Florian Westphal >=20 > [ Upstream commit fa5950e498e7face21a1761f327e6c1152f778c3 ] >=20 > None of these spots really needs to crash the kernel. > In one two cases we can jsut report error to userspace, in the other > cases we can just use WARN_ON (and leak memory instead). Do these conditions trigger for someone, to warrant -stable patch? > +++ b/net/netfilter/nft_cmp.c > @@ -79,7 +79,8 @@ static int nft_cmp_init(const struct nft_ctx *ctx, cons= t struct nft_expr *expr, > =20 > err =3D nft_data_init(NULL, &priv->data, sizeof(priv->data), &desc, > tb[NFTA_CMP_DATA]); > - BUG_ON(err < 0); > + if (err < 0) > + return err; > =20 > priv->sreg =3D nft_parse_register(tb[NFTA_CMP_SREG]); > err =3D nft_validate_register_load(priv->sreg, desc.len); > @@ -129,7 +130,8 @@ static int nft_cmp_fast_init(const struct nft_ctx *ct= x, > =20 > err =3D nft_data_init(NULL, &data, sizeof(data), &desc, > tb[NFTA_CMP_DATA]); > - BUG_ON(err < 0); > + if (err < 0) > + return err; > =20 > priv->sreg =3D nft_parse_register(tb[NFTA_CMP_SREG]); > err =3D nft_validate_register_load(priv->sreg, desc.len); This goes from "kill kernel with backtrace" to "silently return failure". Should WARN_ON() be preserved here? Best regards, Pavel =09 --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --cvVnyQ+4j833TQvp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCXdbwkgAKCRAw5/Bqldv6 8l5qAKC9n9Z+1mVzS9IM9LaSttCq2lqVeACgp6Ckp2puBkyXe9dWOAY6omkyMYQ= =edJ9 -----END PGP SIGNATURE----- --cvVnyQ+4j833TQvp--