linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Brian Norris <briannorris@chromium.org>,
	Kalle Valo <kvalo@codeaurora.org>,
	Sasha Levin <sashal@kernel.org>,
	linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH AUTOSEL 4.4 12/68] mwifiex: debugfs: correct histogram spacing, formatting
Date: Fri, 22 Nov 2019 01:12:05 -0500	[thread overview]
Message-ID: <20191122061301.4947-11-sashal@kernel.org> (raw)
In-Reply-To: <20191122061301.4947-1-sashal@kernel.org>

From: Brian Norris <briannorris@chromium.org>

[ Upstream commit 4cb777c64e030778c569f605398d7604d8aabc0f ]

Currently, snippets of this file look like:

rx rates (in Mbps): 0=1M   1=2M2=5.5M  3=11M   4=6M   5=9M  6=12M
7=18M  8=24M  9=36M  10=48M  11=54M12-27=MCS0-15(BW20) 28-43=MCS0-15(BW40)
44-53=MCS0-9(VHT:BW20)54-63=MCS0-9(VHT:BW40)64-73=MCS0-9(VHT:BW80)
...
noise_flr[--96dBm] = 22
noise_flr[--95dBm] = 149
noise_flr[--94dBm] = 9
noise_flr[--93dBm] = 2

We're missing some spaces, and we're adding a minus sign ('-') on values
that are already negative signed integers.

Signed-off-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/net/wireless/mwifiex/debugfs.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/drivers/net/wireless/mwifiex/debugfs.c b/drivers/net/wireless/mwifiex/debugfs.c
index 45d97b64ef84b..f72c4f8853111 100644
--- a/drivers/net/wireless/mwifiex/debugfs.c
+++ b/drivers/net/wireless/mwifiex/debugfs.c
@@ -295,15 +295,13 @@ mwifiex_histogram_read(struct file *file, char __user *ubuf,
 		     "total samples = %d\n",
 		     atomic_read(&phist_data->num_samples));
 
-	p += sprintf(p, "rx rates (in Mbps): 0=1M   1=2M");
-	p += sprintf(p, "2=5.5M  3=11M   4=6M   5=9M  6=12M\n");
-	p += sprintf(p, "7=18M  8=24M  9=36M  10=48M  11=54M");
-	p += sprintf(p, "12-27=MCS0-15(BW20) 28-43=MCS0-15(BW40)\n");
+	p += sprintf(p,
+		     "rx rates (in Mbps): 0=1M   1=2M 2=5.5M  3=11M   4=6M   5=9M  6=12M\n"
+		     "7=18M  8=24M  9=36M  10=48M  11=54M 12-27=MCS0-15(BW20) 28-43=MCS0-15(BW40)\n");
 
 	if (ISSUPP_11ACENABLED(priv->adapter->fw_cap_info)) {
-		p += sprintf(p, "44-53=MCS0-9(VHT:BW20)");
-		p += sprintf(p, "54-63=MCS0-9(VHT:BW40)");
-		p += sprintf(p, "64-73=MCS0-9(VHT:BW80)\n\n");
+		p += sprintf(p,
+			     "44-53=MCS0-9(VHT:BW20) 54-63=MCS0-9(VHT:BW40) 64-73=MCS0-9(VHT:BW80)\n\n");
 	} else {
 		p += sprintf(p, "\n");
 	}
@@ -332,7 +330,7 @@ mwifiex_histogram_read(struct file *file, char __user *ubuf,
 	for (i = 0; i < MWIFIEX_MAX_NOISE_FLR; i++) {
 		value = atomic_read(&phist_data->noise_flr[i]);
 		if (value)
-			p += sprintf(p, "noise_flr[-%02ddBm] = %d\n",
+			p += sprintf(p, "noise_flr[%02ddBm] = %d\n",
 				(int)(i-128), value);
 	}
 	for (i = 0; i < MWIFIEX_MAX_SIG_STRENGTH; i++) {
-- 
2.20.1


  parent reply	other threads:[~2019-11-22  6:13 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-22  6:11 [PATCH AUTOSEL 4.4 01/68] scsi: lpfc: Fix dif and first burst use in write commands Sasha Levin
2019-11-22  6:11 ` [PATCH AUTOSEL 4.4 03/68] ARM: dts: imx53-voipac-dmm-668: Fix memory node duplication Sasha Levin
2019-11-22  6:11 ` [PATCH AUTOSEL 4.4 04/68] parisc: Fix serio address output Sasha Levin
2019-11-22  6:11 ` [PATCH AUTOSEL 4.4 05/68] parisc: Fix HP SDC hpa " Sasha Levin
2019-11-22  6:11 ` [PATCH AUTOSEL 4.4 06/68] arm64: smp: Handle errors reported by the firmware Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 07/68] PM / AVS: SmartReflex: NULL check before some freeing functions is not needed Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 08/68] ARM: ks8695: fix section mismatch warning Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 09/68] ACPI / LPSS: Ignore acpi_device_fix_up_power() return value Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 10/68] crypto: user - support incremental algorithm dumps Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 11/68] mwifiex: fix potential NULL dereference and use after free Sasha Levin
2019-11-22  6:12 ` Sasha Levin [this message]
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 13/68] rtl818x: fix potential " Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 14/68] xfs: require both realtime inodes to mount Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 15/68] ubi: Put MTD device after it is not used Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 16/68] ubi: Do not drop UBI device reference before using Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 17/68] microblaze: adjust the help to the real behavior Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 18/68] microblaze: move "... is ready" messages to arch/microblaze/Makefile Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 19/68] gpiolib: Fix return value of gpio_to_desc() stub if !GPIOLIB Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 20/68] VSOCK: bind to random port for VMADDR_PORT_ANY Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 21/68] btrfs: only track ref_heads in delayed_ref_updates Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 22/68] xen/pciback: Check dev_data before using it Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 23/68] KVM: s390: unregister debug feature on failing arch init Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 24/68] pinctrl: sh-pfc: sh7264: Fix PFCR3 and PFCR0 register configuration Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 25/68] pinctrl: sh-pfc: sh7734: Fix shifted values in IPSR10 Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 26/68] HID: doc: fix wrong data structure reference for UHID_OUTPUT Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 27/68] gfs2: take jdata unstuff into account in do_grow Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 28/68] xfs: Align compat attrlist_by_handle with native implementation Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 29/68] IB/qib: Fix an error code in qib_sdma_verbs_send() Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 30/68] powerpc/book3s/32: fix number of bats in p/v_block_mapped() Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 31/68] powerpc/xmon: fix dump_segments() Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 32/68] drivers/regulator: fix a missing check of return value Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 33/68] serial: max310x: Fix tx_empty() callback Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 34/68] openrisc: Fix broken paths to arch/or32 Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 35/68] RDMA/srp: Propagate ib_post_send() failures to the SCSI mid-layer Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 36/68] scsi: qla2xxx: deadlock by configfs_depend_item Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 37/68] scsi: csiostor: fix incorrect dma device in case of vport Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 38/68] ath6kl: Only use match sets when firmware supports it Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 39/68] ath6kl: Fix off by one error in scan completion Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 40/68] powerpc/prom: fix early DEBUG messages Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 41/68] powerpc/mm: Make NULL pointer deferences explicit on bad page faults Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 42/68] powerpc/44x/bamboo: Fix PCI range Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 43/68] drbd: reject attach of unsuitable uuids even if connected Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 44/68] drbd: fix print_st_err()'s prototype to match the definition Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 45/68] regulator: tps65910: fix a missing check of return value Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 46/68] net/net_namespace: Check the return value of register_pernet_subsys() Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 47/68] um: Make GCOV depend on !KCOV Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 48/68] net: stmicro: fix a missing check of clk_prepare Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 49/68] atl1e: checking the status of atl1e_write_phy_reg Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 50/68] tipc: fix a missing check of genlmsg_put Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 51/68] ocfs2: clear journal dirty flag after shutdown journal Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 52/68] lib/genalloc.c: use vzalloc_node() to allocate the bitmap Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 53/68] lib/genalloc.c: include vmalloc.h Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 54/68] mtd: Check add_mtd_device() ret code Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 55/68] tipc: fix memory leak in tipc_nl_compat_publ_dump Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 56/68] net/core/neighbour: tell kmemleak about hash tables Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 57/68] net/core/neighbour: fix kmemleak minimal reference count for " Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 58/68] sfc: suppress duplicate nvmem partition types in efx_ef10_mtd_probe Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 59/68] decnet: fix DN_IFREQ_SIZE Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 60/68] tipc: fix skb may be leaky in tipc_link_input Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 61/68] sfc: initialise found bitmap in efx_ef10_mtd_probe Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 62/68] net: fix possible overflow in __sk_mem_raise_allocated() Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 63/68] net: dev: Use unsigned integer as an argument to left-shift Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 64/68] scsi: libsas: Support SATA PHY connection rate unmatch fixing during discovery Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 65/68] ACPI / APEI: Switch estatus pool to use vmalloc memory Sasha Levin
2019-11-22  6:12 ` [PATCH AUTOSEL 4.4 66/68] scsi: libsas: Check SMP PHY control function result Sasha Levin
2019-11-22  6:13 ` [PATCH AUTOSEL 4.4 67/68] powerpc/pseries/dlpar: Fix a missing check in dlpar_parse_cc_property() Sasha Levin
2019-11-22  6:13 ` [PATCH AUTOSEL 4.4 68/68] mtd: Remove a debug trace in mtdpart.c Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191122061301.4947-11-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=briannorris@chromium.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).