From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61C37C432C0 for ; Fri, 22 Nov 2019 11:09:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 378F02070E for ; Fri, 22 Nov 2019 11:09:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730305AbfKVLJe (ORCPT ); Fri, 22 Nov 2019 06:09:34 -0500 Received: from helcar.hmeau.com ([216.24.177.18]:53330 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731399AbfKVLDF (ORCPT ); Fri, 22 Nov 2019 06:03:05 -0500 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1iY6iB-0004Ri-J1; Fri, 22 Nov 2019 19:02:51 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1iY6iA-0002dc-SI; Fri, 22 Nov 2019 19:02:50 +0800 Date: Fri, 22 Nov 2019 19:02:50 +0800 From: Herbert Xu To: YueHaibing Cc: davem@davemloft.net, cyrille.pitchen@atmel.com, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 -next] crypto: atmel - Fix build error of CRYPTO_AUTHENC Message-ID: <20191122110250.3cs2fmgpjptxmbt6@gondor.apana.org.au> References: <20191112072405.40268-1-yuehaibing@huawei.com> <20191113095550.15104-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191113095550.15104-1-yuehaibing@huawei.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 13, 2019 at 05:55:50PM +0800, YueHaibing wrote: > If CRYPTO_DEV_ATMEL_AUTHENC is m, CRYPTO_DEV_ATMEL_SHA is m, > but CRYPTO_DEV_ATMEL_AES is y, building will fail: > > drivers/crypto/atmel-aes.o: In function `atmel_aes_authenc_init_tfm': > atmel-aes.c:(.text+0x670): undefined reference to `atmel_sha_authenc_get_reqsize' > atmel-aes.c:(.text+0x67a): undefined reference to `atmel_sha_authenc_spawn' > drivers/crypto/atmel-aes.o: In function `atmel_aes_authenc_setkey': > atmel-aes.c:(.text+0x7e5): undefined reference to `atmel_sha_authenc_setkey' > > Make CRYPTO_DEV_ATMEL_AUTHENC depend on CRYPTO_DEV_ATMEL_AES, > and select CRYPTO_DEV_ATMEL_SHA and CRYPTO_AUTHENC for it under there. > > Reported-by: Hulk Robot > Suggested-by: Herbert Xu > Fixes: 89a82ef87e01 ("crypto: atmel-authenc - add support to...") > Signed-off-by: YueHaibing > Reviewed-by: Tudor Ambarus > --- > v3: fix log typo > v2: make CRYPTO_DEV_ATMEL_AUTHENC depends on DEV_ATMEL_AES > --- > drivers/crypto/Kconfig | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt