From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84F83C432C0 for ; Fri, 22 Nov 2019 11:05:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 582902088F for ; Fri, 22 Nov 2019 11:05:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731644AbfKVLE7 (ORCPT ); Fri, 22 Nov 2019 06:04:59 -0500 Received: from helcar.hmeau.com ([216.24.177.18]:53552 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731108AbfKVLE5 (ORCPT ); Fri, 22 Nov 2019 06:04:57 -0500 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1iY6k3-0004dS-9n; Fri, 22 Nov 2019 19:04:47 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1iY6k2-0002gT-BV; Fri, 22 Nov 2019 19:04:46 +0800 Date: Fri, 22 Nov 2019 19:04:46 +0800 From: Herbert Xu To: Sami Tolvanen Cc: Ard Biesheuvel , Eric Biggers , Kees Cook , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Ard Biesheuvel Subject: Re: [PATCH v3] crypto: arm64/sha: fix function types Message-ID: <20191122110446.wjuyo5b5i3ebqbsd@gondor.apana.org.au> References: <20191112223046.176097-1-samitolvanen@google.com> <20191119201353.2589-1-samitolvanen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191119201353.2589-1-samitolvanen@google.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 19, 2019 at 12:13:53PM -0800, Sami Tolvanen wrote: > Instead of casting pointers to callback functions, add C wrappers > to avoid type mismatch failures with Control-Flow Integrity (CFI) > checking. > > Signed-off-by: Sami Tolvanen > Reviewed-by: Ard Biesheuvel > --- > Changes in v3: > - Removed unnecessary inline attributes. > > Changes in v2: > - Added wrapper functions instead of changing parameter types > for the assembly functions. > > --- > arch/arm64/crypto/sha1-ce-glue.c | 17 +++++++++------ > arch/arm64/crypto/sha2-ce-glue.c | 34 ++++++++++++++++++------------ > arch/arm64/crypto/sha256-glue.c | 32 +++++++++++++++++----------- > arch/arm64/crypto/sha512-ce-glue.c | 26 ++++++++++++----------- > arch/arm64/crypto/sha512-glue.c | 15 ++++++++----- > 5 files changed, 76 insertions(+), 48 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt