From: Mel Gorman <mgorman@techsingularity.net>
To: Doug Smythies <dsmythies@telus.net>
Cc: 'Giovanni Gherdovich' <ggherdovich@suse.cz>,
'Srinivas Pandruvada' <srinivas.pandruvada@linux.intel.com>,
'Thomas Gleixner' <tglx@linutronix.de>,
'Ingo Molnar' <mingo@redhat.com>,
'Peter Zijlstra' <peterz@infradead.org>,
'Borislav Petkov' <bp@suse.de>, 'Len Brown' <lenb@kernel.org>,
"'Rafael J . Wysocki'" <rjw@rjwysocki.net>,
x86@kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org,
'Matt Fleming' <matt@codeblueprint.co.uk>,
'Viresh Kumar' <viresh.kumar@linaro.org>,
'Juri Lelli' <juri.lelli@redhat.com>,
'Paul Turner' <pjt@google.com>,
'Vincent Guittot' <vincent.guittot@linaro.org>,
'Quentin Perret' <qperret@qperret.net>,
'Dietmar Eggemann' <dietmar.eggemann@arm.com>
Subject: Re: [PATCH v4 1/6] x86,sched: Add support for frequency invariance
Date: Mon, 25 Nov 2019 09:16:37 +0000 [thread overview]
Message-ID: <20191125091637.GB3016@techsingularity.net> (raw)
In-Reply-To: <000001d5a29b$c944fd70$5bcef850$@net>
On Sat, Nov 23, 2019 at 11:49:57PM -0800, Doug Smythies wrote:
> Hi all,
>
> The address list here is likely incorrect,
> and this e-mail is really about a kernel 5.4
> bisected regression.
>
> It had been since mid September, and kernel 5.3-rc8 since
> I had tried this, so I wanted to try it again. Call it due diligence.
> I focused on my own version of the "gitsource" test.
>
> Kernel 5.4-rc8 (as a baseline reference).
>
> My results were extremely surprising.
>
> As it turns out, at least on my test computer, both the
> acpi-cpufreq and intel_cpufreq CPU frequency scaling drivers
> using the schedutil governor are broken. For the tests that
> I ran, there is negligible difference between them and the
> performance governor. So, one might argue that they are not
> broken, but rather working incredibly well, which if true
> then this patch is no longer needed.
>
I don't think that is necessarily fair. It still makes sense that the
"size" of a task is independent of the frequency the CPU is running at
for load balancing decisions and should be merged on that basis alone. If
the scheduler made perfect decisions on task location then there would
be negligible difference between ondemand (or powersave if intel_pstate)
and performance governor too. cpufreq tends to be more noticable under
the current implementation as tasks are a lot more mobile than they need
to be for basic workloads.
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2019-11-25 9:16 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 12:46 [PATCH v4 0/6] Add support for frequency invariance for (some) x86 Giovanni Gherdovich
2019-11-13 12:46 ` [PATCH v4 1/6] x86,sched: Add support for frequency invariance Giovanni Gherdovich
2019-11-24 7:49 ` Doug Smythies
2019-11-25 8:16 ` Doug Smythies
2019-11-25 9:16 ` Mel Gorman [this message]
2019-11-25 16:06 ` Giovanni Gherdovich
2019-11-26 5:59 ` Doug Smythies
2019-11-26 15:20 ` Giovanni Gherdovich
2019-11-27 7:32 ` Doug Smythies
2019-11-28 22:48 ` Doug Smythies
2019-12-19 10:48 ` Qais Yousef
2019-12-23 7:47 ` Doug Smythies
2019-12-23 14:07 ` Qais Yousef
2019-12-23 14:40 ` Qais Yousef
2019-12-23 16:34 ` Doug Smythies
2019-12-23 19:10 ` Qais Yousef
2019-12-24 1:16 ` Doug Smythies
2019-12-24 11:08 ` Qais Yousef
2019-12-02 16:34 ` Ionela Voinescu
2019-12-06 11:57 ` Giovanni Gherdovich
2019-12-18 19:34 ` Peter Zijlstra
2019-12-19 20:27 ` Giovanni Gherdovich
2019-11-13 12:46 ` [PATCH v4 2/6] x86,sched: Add support for frequency invariance on SKYLAKE_X Giovanni Gherdovich
2019-12-18 20:06 ` Peter Zijlstra
2019-12-19 20:29 ` Giovanni Gherdovich
2019-11-13 12:46 ` [PATCH v4 3/6] x86,sched: Add support for frequency invariance on XEON_PHI_KNL/KNM Giovanni Gherdovich
2019-12-18 20:22 ` Peter Zijlstra
2019-12-19 20:32 ` Giovanni Gherdovich
2019-11-13 12:46 ` [PATCH v4 4/6] x86,sched: Add support for frequency invariance on ATOM_GOLDMONT* Giovanni Gherdovich
2019-11-13 12:46 ` [PATCH v4 5/6] x86,sched: Add support for frequency invariance on ATOM Giovanni Gherdovich
2019-11-13 16:50 ` Srinivas Pandruvada
2019-11-15 10:34 ` Giovanni Gherdovich
2019-11-13 12:46 ` [PATCH v4 6/6] x86: intel_pstate: handle runtime turbo disablement/enablement in freq. invariance Giovanni Gherdovich
2019-12-18 20:37 ` [PATCH v4 0/6] Add support for frequency invariance for (some) x86 Peter Zijlstra
2019-12-19 20:33 ` Giovanni Gherdovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191125091637.GB3016@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=bp@suse.de \
--cc=dietmar.eggemann@arm.com \
--cc=dsmythies@telus.net \
--cc=ggherdovich@suse.cz \
--cc=juri.lelli@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=qperret@qperret.net \
--cc=rjw@rjwysocki.net \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).