From: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: dsterba@suse.com, linux-btrfs@vger.kernel.org,
anand.jain@oracle.com, Marcos Paulo de Souza <mpdesouza@suse.com>
Subject: [PATCH 0/2] btrfs qgroup cleanup
Date: Mon, 25 Nov 2019 21:58:49 -0300 [thread overview]
Message-ID: <20191126005851.11813-1-marcos.souza.org@gmail.com> (raw)
From: Marcos Paulo de Souza <mpdesouza@suse.com>
While reading the qgroup code and doing some tests, I found some two things
that I would like to change:
* Remove some useless code that was being set only to check if
fs_info->quota_root was not NULL
* Check why creating a qgroup was returning EINVAL
The answer to the second point was: EINVAL is returned when a user tries to
create/delete/list/assign a qgroup to a subvolume, but this subvolume does
not have quota enabled. Talking with David, he suggested to change it to
ENOTCONN, following what is currently being used in balance and scrub.
So here are the changes. Please take a look!
Marcos Paulo de Souza (2):
btrfs: qgroup: Cleanup quota_root checks
btrfs: qgroup: Return -ENOTCONN instead of -EINVAL
fs/btrfs/qgroup.c | 44 +++++++++++++++-----------------------------
1 file changed, 15 insertions(+), 29 deletions(-)
--
2.23.0
next reply other threads:[~2019-11-26 0:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 0:58 Marcos Paulo de Souza [this message]
2019-11-26 0:58 ` [PATCH 1/2] btrfs: qgroup: Cleanup quota_root checks Marcos Paulo de Souza
2019-11-26 2:47 ` Qu Wenruo
2019-11-26 0:58 ` [PATCH 2/2] btrfs: qgroup: Return -ENOTCONN instead of -EINVAL Marcos Paulo de Souza
2019-11-26 2:50 ` Qu Wenruo
2019-11-26 17:00 ` [PATCH 0/2] btrfs qgroup cleanup David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191126005851.11813-1-marcos.souza.org@gmail.com \
--to=marcos.souza.org@gmail.com \
--cc=anand.jain@oracle.com \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpdesouza@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).