From: Mark Brown <broonie@kernel.org>
To: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Cc: Sebastian Reichel <sebastian.reichel@collabora.com>,
Support Opensource <Support.Opensource@diasemi.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel@collabora.com" <kernel@collabora.com>
Subject: Re: [PATCHv2 6/6] ASoC: da7213: Add default clock handling
Date: Tue, 26 Nov 2019 17:50:40 +0000 [thread overview]
Message-ID: <20191126175040.GD4205@sirena.org.uk> (raw)
In-Reply-To: <AM5PR1001MB09949D557742E8817545637F80450@AM5PR1001MB0994.EURPRD10.PROD.OUTLOOK.COM>
[-- Attachment #1: Type: text/plain, Size: 1365 bytes --]
On Tue, Nov 26, 2019 at 05:39:45PM +0000, Adam Thomson wrote:
> On 26 November 2019 17:09, Mark Brown wrote:
> > If we're special casing simple-card we're doing it wrong - there's
> > nothing stopping any other machine driver behaving in the same way.
> Ok, what's being proposed here is for the codec to automatically control the PLL
> rather than leaving it to the machine driver as is the case right now. In the
> possible scenario where this is done using a card level widget to enable/disable
Wasn't the proposal to add a new mode where the machine driver *could*
choose to delgate PLL selection to the CODEC driver rather than do so
unconditionally?
> the PLL we will conflict with that using the current suggested approach for the
> da7213 driver, albeit with no real consequence other than configuring the PLL
> twice the first time a stream is started. It's a case of how to determine who's
> in control of the PLL here; machine driver or codec?
The patch looked like the idea was that as soon as the machine driver
configures the PLL the CODEC driver will stop touching it which looked
like a reasonable way of doing it, you could also do it with an explicit
SYSCLK value (which would have to be 0 for generic machine drivers to
pick it up) but this works just as well and may even be better. Perhaps
I misread it though.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-11-26 17:50 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 15:24 [PATCHv2 0/6] ASoC: da7213: support for usage with simple-card Sebastian Reichel
2019-11-20 15:24 ` [PATCHv2 1/6] ASoC: da7213: Add da7212 DT compatible Sebastian Reichel
2019-11-21 20:10 ` Adam Thomson
2019-11-22 17:20 ` Sebastian Reichel
2019-11-20 15:24 ` [PATCHv2 2/6] ASoC: da7213: Add regulator support Sebastian Reichel
2019-11-21 21:15 ` Adam Thomson
2019-11-22 17:09 ` Sebastian Reichel
2019-11-26 17:02 ` Adam Thomson
2019-11-20 15:24 ` [PATCHv2 3/6] ASoC: da7213: Provide selectable option Sebastian Reichel
2019-11-26 17:05 ` Adam Thomson
2019-11-20 15:24 ` [PATCHv2 4/6] ASoC: da7213: Move set_sysclk to codec level Sebastian Reichel
2019-11-26 17:09 ` Adam Thomson
2019-11-20 15:24 ` [PATCHv2 5/6] ASoC: da7213: Move set_pll " Sebastian Reichel
2019-11-26 17:10 ` Adam Thomson
2019-11-20 15:24 ` [PATCHv2 6/6] ASoC: da7213: Add default clock handling Sebastian Reichel
2019-11-21 21:49 ` Adam Thomson
2019-11-26 16:55 ` Adam Thomson
2019-11-26 17:08 ` Mark Brown
2019-11-26 17:39 ` Adam Thomson
2019-11-26 17:50 ` Mark Brown [this message]
2019-11-27 11:32 ` Adam Thomson
2019-11-27 12:33 ` Mark Brown
2019-11-27 13:42 ` Adam Thomson
2019-11-27 15:40 ` Mark Brown
2019-11-27 16:33 ` Adam Thomson
2019-11-27 16:41 ` Mark Brown
2019-11-27 18:10 ` Adam Thomson
2019-11-28 13:13 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191126175040.GD4205@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=Support.Opensource@diasemi.com \
--cc=alsa-devel@alsa-project.org \
--cc=kernel@collabora.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=sebastian.reichel@collabora.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).