linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] iio: adc: stm32-dfsdm: fix single conversion
@ 2019-11-27 13:07 Olivier Moysan
  2019-11-27 16:13 ` Fabrice Gasnier
  2020-01-10 10:05 ` Olivier MOYSAN
  0 siblings, 2 replies; 4+ messages in thread
From: Olivier Moysan @ 2019-11-27 13:07 UTC (permalink / raw)
  To: jic23, knaack.h, lars, pmeerw, mcoquelin.stm32, alexandre.torgue,
	fabrice.gasnier, linux-iio, linux-stm32, linux-arm-kernel,
	linux-kernel, benjamin.gaignard, olivier.moysan

Apply data formatting to single conversion,
as this is already done in continuous and trigger modes.

Fixes: 102afde62937 ("iio: adc: stm32-dfsdm: manage data resolution in trigger mode")

Signed-off-by: Olivier Moysan <olivier.moysan@st.com>
---
changes in version 2:
- correct title
---
 drivers/iio/adc/stm32-dfsdm-adc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c
index e493242c266e..0339ecdd06bd 100644
--- a/drivers/iio/adc/stm32-dfsdm-adc.c
+++ b/drivers/iio/adc/stm32-dfsdm-adc.c
@@ -1204,6 +1204,8 @@ static int stm32_dfsdm_single_conv(struct iio_dev *indio_dev,
 
 	stm32_dfsdm_stop_conv(adc);
 
+	stm32_dfsdm_process_data(adc, res);
+
 stop_dfsdm:
 	stm32_dfsdm_stop_dfsdm(adc->dfsdm);
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH v2] iio: adc: stm32-dfsdm: fix single conversion
  2019-11-27 13:07 [PATCH v2] iio: adc: stm32-dfsdm: fix single conversion Olivier Moysan
@ 2019-11-27 16:13 ` Fabrice Gasnier
  2020-01-10 10:05 ` Olivier MOYSAN
  1 sibling, 0 replies; 4+ messages in thread
From: Fabrice Gasnier @ 2019-11-27 16:13 UTC (permalink / raw)
  To: Olivier Moysan, jic23, knaack.h, lars, pmeerw, mcoquelin.stm32,
	alexandre.torgue, linux-iio, linux-stm32, linux-arm-kernel,
	linux-kernel, benjamin.gaignard

On 11/27/19 2:07 PM, Olivier Moysan wrote:
> Apply data formatting to single conversion,
> as this is already done in continuous and trigger modes.
> 
> Fixes: 102afde62937 ("iio: adc: stm32-dfsdm: manage data resolution in trigger mode")
> 
> Signed-off-by: Olivier Moysan <olivier.moysan@st.com>
Hi Olivier,

Acked-by: Fabrice Gasnier <fabrice.gasnier@st.com>

Thanks,
Fabrice

> ---
> changes in version 2:
> - correct title
> ---
>  drivers/iio/adc/stm32-dfsdm-adc.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c
> index e493242c266e..0339ecdd06bd 100644
> --- a/drivers/iio/adc/stm32-dfsdm-adc.c
> +++ b/drivers/iio/adc/stm32-dfsdm-adc.c
> @@ -1204,6 +1204,8 @@ static int stm32_dfsdm_single_conv(struct iio_dev *indio_dev,
>  
>  	stm32_dfsdm_stop_conv(adc);
>  
> +	stm32_dfsdm_process_data(adc, res);
> +
>  stop_dfsdm:
>  	stm32_dfsdm_stop_dfsdm(adc->dfsdm);
>  
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH v2] iio: adc: stm32-dfsdm: fix single conversion
  2019-11-27 13:07 [PATCH v2] iio: adc: stm32-dfsdm: fix single conversion Olivier Moysan
  2019-11-27 16:13 ` Fabrice Gasnier
@ 2020-01-10 10:05 ` Olivier MOYSAN
  2020-01-13 21:58   ` Jonathan Cameron
  1 sibling, 1 reply; 4+ messages in thread
From: Olivier MOYSAN @ 2020-01-10 10:05 UTC (permalink / raw)
  To: jic23, knaack.h, lars, pmeerw, mcoquelin.stm32, Alexandre TORGUE,
	Fabrice GASNIER, linux-iio, linux-stm32, linux-arm-kernel,
	linux-kernel, Benjamin GAIGNARD

Hi Jonathan, all,

Kind reminder on this patch.
Regards
Olivier

On 11/27/19 2:07 PM, Olivier Moysan wrote:
> Apply data formatting to single conversion,
> as this is already done in continuous and trigger modes.
>
> Fixes: 102afde62937 ("iio: adc: stm32-dfsdm: manage data resolution in trigger mode")
>
> Signed-off-by: Olivier Moysan <olivier.moysan@st.com>
> ---
> changes in version 2:
> - correct title
> ---
>   drivers/iio/adc/stm32-dfsdm-adc.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c
> index e493242c266e..0339ecdd06bd 100644
> --- a/drivers/iio/adc/stm32-dfsdm-adc.c
> +++ b/drivers/iio/adc/stm32-dfsdm-adc.c
> @@ -1204,6 +1204,8 @@ static int stm32_dfsdm_single_conv(struct iio_dev *indio_dev,
>   
>   	stm32_dfsdm_stop_conv(adc);
>   
> +	stm32_dfsdm_process_data(adc, res);
> +
>   stop_dfsdm:
>   	stm32_dfsdm_stop_dfsdm(adc->dfsdm);
>   

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH v2] iio: adc: stm32-dfsdm: fix single conversion
  2020-01-10 10:05 ` Olivier MOYSAN
@ 2020-01-13 21:58   ` Jonathan Cameron
  0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2020-01-13 21:58 UTC (permalink / raw)
  To: Olivier MOYSAN
  Cc: knaack.h, lars, pmeerw, mcoquelin.stm32, Alexandre TORGUE,
	Fabrice GASNIER, linux-iio, linux-stm32, linux-arm-kernel,
	linux-kernel, Benjamin GAIGNARD

On Fri, 10 Jan 2020 10:05:47 +0000
Olivier MOYSAN <olivier.moysan@st.com> wrote:

> Hi Jonathan, all,
> 
> Kind reminder on this patch.

Gah. Sorry .I marked it to reply then forgot to actually come back and do so.

Thanks for the reminder.  Given timing I'll apply this to the togreg branch
of iio.git and get it lined up for the merge window.  Marked it for stable
so it should quickly get applied to stable as appropriate after that.

Sorry for the delay.

Thanks,

Jonathan

> Regards
> Olivier
> 
> On 11/27/19 2:07 PM, Olivier Moysan wrote:
> > Apply data formatting to single conversion,
> > as this is already done in continuous and trigger modes.
> >
> > Fixes: 102afde62937 ("iio: adc: stm32-dfsdm: manage data resolution in trigger mode")
> >
> > Signed-off-by: Olivier Moysan <olivier.moysan@st.com>
> > ---
> > changes in version 2:
> > - correct title
> > ---
> >   drivers/iio/adc/stm32-dfsdm-adc.c | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c
> > index e493242c266e..0339ecdd06bd 100644
> > --- a/drivers/iio/adc/stm32-dfsdm-adc.c
> > +++ b/drivers/iio/adc/stm32-dfsdm-adc.c
> > @@ -1204,6 +1204,8 @@ static int stm32_dfsdm_single_conv(struct iio_dev *indio_dev,
> >   
> >   	stm32_dfsdm_stop_conv(adc);
> >   
> > +	stm32_dfsdm_process_data(adc, res);
> > +
> >   stop_dfsdm:
> >   	stm32_dfsdm_stop_dfsdm(adc->dfsdm);
> >     


^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-01-13 21:58 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-27 13:07 [PATCH v2] iio: adc: stm32-dfsdm: fix single conversion Olivier Moysan
2019-11-27 16:13 ` Fabrice Gasnier
2020-01-10 10:05 ` Olivier MOYSAN
2020-01-13 21:58   ` Jonathan Cameron

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).