linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dennis Zhou <dennis@kernel.org>
To: Christopher Lameter <cl@linux.com>
Cc: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
	Dennis Zhou <dennis@kernel.org>,
	Ben Dooks <ben.dooks@codethink.co.uk>,
	linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
	Tejun Heo <tj@kernel.org>, Nicholas Piggin <npiggin@gmail.com>,
	Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] fix __percpu annotation in asm-generic
Date: Wed, 27 Nov 2019 12:53:50 -0500	[thread overview]
Message-ID: <20191127175350.GA52308@dennisz-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1911271553560.16980@www.lameter.com>

On Wed, Nov 27, 2019 at 03:55:19PM +0000, Christopher Lameter wrote:
> On Tue, 26 Nov 2019, Luc Van Oostenryck wrote:
> 
> > So, fix the declaration of the 'pcp' variable to its correct type:
> > the plain (non-percpu) pointer corresponding to its address.
> > Same for raw_cpu_generic_xchg(), raw_cpu_generic_cmpxchg() &
> > raw_cpu_generic_cmpxchg_double().
> 
> Acked-by: Christoph Lameter <cl@linux.com>
> 
> Maybe a better fix is to come up with a typeof_strip_percu() or so
> macro for all the places where this needs to be done?

I like the idea of typeof_strip_percpu(). Luc do you mind spinning v2
with a macro for this instead?

Thanks,
Dennis

  reply	other threads:[~2019-11-27 17:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-26 20:06 [PATCH] fix __percpu annotation in asm-generic Luc Van Oostenryck
2019-11-27 15:55 ` Christopher Lameter
2019-11-27 17:53   ` Dennis Zhou [this message]
2019-11-27 22:54     ` Luc Van Oostenryck
2019-11-29 18:11       ` Christopher Lameter
2019-11-30  0:00         ` Luc Van Oostenryck
2019-12-02 19:07           ` Dennis Zhou
2019-12-02 19:42             ` Christopher Lameter
2019-12-03  3:01             ` Luc Van Oostenryck
2020-03-24  4:13           ` Jason A. Donenfeld
2020-03-24  6:44             ` Luc Van Oostenryck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191127175350.GA52308@dennisz-mbp.dhcp.thefacebook.com \
    --to=dennis@kernel.org \
    --cc=arnd@arndb.de \
    --cc=ben.dooks@codethink.co.uk \
    --cc=cl@linux.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luc.vanoostenryck@gmail.com \
    --cc=npiggin@gmail.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).