From: "Ondřej Jirman" <megous@megous.com>
To: Maxime Ripard <mripard@kernel.org>
Cc: Vasily Khoruzhick <anarsoul@gmail.com>,
Yangtao Li <tiny.windzz@gmail.com>,
Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Amit Kucheria <amit.kucheria@verdurent.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, Chen-Yu Tsai <wens@csie.org>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/7] dt-bindings: thermal: add YAML schema for sun8i-thermal driver bindings
Date: Wed, 27 Nov 2019 19:07:43 +0100 [thread overview]
Message-ID: <20191127180743.ww5npenlg2urxtjn@core.my.home> (raw)
In-Reply-To: <20191127174434.wousbqosmm5vxcsu@gilmour.lan>
Hi,
On Wed, Nov 27, 2019 at 06:44:34PM +0100, Maxime Ripard wrote:
> Hi,
>
> On Tue, Nov 26, 2019 at 09:29:30PM -0800, Vasily Khoruzhick wrote:
> > From: Yangtao Li <tiny.windzz@gmail.com>
> >
> > sun8i-thermal driver supports thermal sensor in wide range of Allwinner
> > SoCs. Add YAML schema for its bindings.
> >
> > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> > Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
> > ---
> > .../thermal/allwinner,sun8i-a83t-ths.yaml | 103 ++++++++++++++++++
> > 1 file changed, 103 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml b/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml
> > new file mode 100644
> > index 000000000000..e622f0a4be90
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml
> > @@ -0,0 +1,103 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/thermal/allwinner,sun8i-a83t-ths.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Allwinner SUN8I Thermal Controller Device Tree Bindings
> > +
> > +maintainers:
> > + - Yangtao Li <tiny.windzz@gmail.com>
> > +
> > +properties:
> > + compatible:
> > + oneOf:
> > + - const: allwinner,sun8i-a83t-ths
> > + - const: allwinner,sun8i-h3-ths
> > + - const: allwinner,sun8i-r40-ths
> > + - const: allwinner,sun50i-a64-ths
> > + - const: allwinner,sun50i-h5-ths
> > + - const: allwinner,sun50i-h6-ths
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > + resets:
> > + maxItems: 1
> > +
> > + clocks:
> > + minItems: 1
> > + maxItems: 2
> > +
> > + clock-names:
> > + anyOf:
> > + - items:
> > + - const: bus
> > + - const: mod
> > + - items:
> > + - const: bus
>
> This can be:
>
> clock-names:
> minItems: 1
Additionally, minItems should be 0, since A83T doesn't have bus clock/reset. And
then there should be a special case for A83T too with min/maxItems = 0 for both
resets and clocks.
regards,
o.
> maxItems: 2
> items:
> - const: bus
> - const: mod
>
> And the length should be checked based on the compatible value, with
> something like
>
> if:
> properties:
> compatible:
> contains:
> const: allwinner,sun50i-h6-ths
>
> then:
> properties:
> clocks:
> maxItems: 1
>
> clock-names:
> maxItems: 1
>
> else:
> properties:
> clocks:
> maxItems: 2
>
> clock-names:
> maxItems: 2
>
> > +
> > + '#thermal-sensor-cells':
> > + enum: [ 0, 1 ]
> > + description: |
> > + Definition depends on soc version:
> > +
> > + For "allwinner,sun8i-h3-ths",
> > + value must be 0.
> > + For all other compatibles
> > + value must be 1.
>
> This should be checked using an if as well.
>
> > +
> > + nvmem-cells:
> > + maxItems: 1
> > + items:
> > + - description: Calibration data for thermal sensors
>
> You can drop the items and just move the description up one level,
> under nvmem-cells
>
> > +
> > + nvmem-cell-names:
> > + items:
> > + - const: calibration
>
> Ditto for the const
>
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - interrupts
> > + - '#thermal-sensor-cells'
>
> Whether clocks, clock-names and resets are thereshould be check using
> an if statement as well.
>
> > +
> > +examples:
> > + - |
> > + ths_a83t: ths@1f04000 {
>
> You don't need the label at all, and the node name should be
> temperature-sensor according to the DT spec, not ths. This applies to
> all you examples.
>
> > + compatible = "allwinner,sun8i-a83t-ths";
> > + reg = <0x01f04000 0x100>;
> > + interrupts = <0 31 0>;
> > + nvmem-cells = <&ths_calibration>;
> > + nvmem-cell-names = "calibration";
> > + #thermal-sensor-cells = <1>;
> > + };
>
> New line.
>
> Thanks!
> Maxime
next prev parent reply other threads:[~2019-11-27 18:07 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 5:29 [PATCH v6 0/7] add thermal sensor driver for A64, A83T, H3, H5, H6, R40 Vasily Khoruzhick
2019-11-27 5:29 ` [PATCH v6 1/7] thermal: sun8i: add thermal driver for H6/H5/H3/A64/A83T/R40 Vasily Khoruzhick
2019-11-27 11:14 ` Ondřej Jirman
2019-11-27 17:35 ` Maxime Ripard
2019-11-27 19:44 ` Frank Lee
2019-11-27 19:48 ` Vasily Khoruzhick
2019-11-27 22:24 ` Ondřej Jirman
2019-11-28 15:16 ` Frank Lee
2019-11-29 0:53 ` Ondřej Jirman
2019-11-28 7:42 ` Maxime Ripard
2019-11-27 17:27 ` Maxime Ripard
2019-11-28 16:43 ` Frank Lee
2019-11-28 17:06 ` Ondřej Jirman
2019-11-29 11:46 ` Frank Lee
2019-12-02 1:58 ` Ondřej Jirman
2019-12-09 18:04 ` Frank Lee
2019-11-27 5:29 ` [PATCH v6 2/7] dt-bindings: thermal: add YAML schema for sun8i-thermal driver bindings Vasily Khoruzhick
2019-11-27 17:44 ` Maxime Ripard
2019-11-27 18:07 ` Ondřej Jirman [this message]
2019-11-27 18:52 ` Vasily Khoruzhick
2019-11-27 20:23 ` Vasily Khoruzhick
2019-11-28 7:43 ` Maxime Ripard
2019-11-28 14:35 ` Frank Lee
2019-11-28 14:45 ` Frank Lee
2019-11-28 16:24 ` Vasily Khoruzhick
2019-11-27 5:29 ` [PATCH v6 3/7] ARM: dts: sun8i-a83t: Add thermal sensor and thermal zones Vasily Khoruzhick
2019-11-27 5:29 ` [PATCH v6 4/7] ARM: dts: sun8i-h3: " Vasily Khoruzhick
2019-11-27 19:40 ` Samuel Holland
2019-11-27 5:29 ` [PATCH v6 5/7] arm64: dts: allwinner: sun50i-h5: " Vasily Khoruzhick
2019-11-27 5:29 ` [PATCH v6 6/7] arm64: dts: allwinner: sun50i-h6: " Vasily Khoruzhick
2019-11-27 5:29 ` [PATCH v6 7/7] arm64: dts: allwinner: a64: Add thermal sensors " Vasily Khoruzhick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191127180743.ww5npenlg2urxtjn@core.my.home \
--to=megous@megous.com \
--cc=amit.kucheria@verdurent.com \
--cc=anarsoul@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab+samsung@kernel.org \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=tiny.windzz@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).