From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: "Jiri Olsa" <jolsa@kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
"Network Development" <netdev@vger.kernel.org>,
bpf <bpf@vger.kernel.org>, "Ingo Molnar" <mingo@kernel.org>,
"Namhyung Kim" <namhyung@kernel.org>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Peter Zijlstra" <a.p.zijlstra@chello.nl>,
"Michael Petlan" <mpetlan@redhat.com>,
"Toke Høiland-Jørgensen" <toke@redhat.com>,
"Jesper Dangaard Brouer" <brouer@redhat.com>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Martin KaFai Lau" <kafai@fb.com>,
"Song Liu" <songliubraving@fb.com>, "Yonghong Song" <yhs@fb.com>,
"Andrii Nakryiko" <andriin@fb.com>
Subject: Re: [PATCH 0/3] perf/bpftool: Allow to link libbpf dynamically
Date: Wed, 27 Nov 2019 15:44:00 -0300 [thread overview]
Message-ID: <20191127184400.GA4063@kernel.org> (raw)
In-Reply-To: <CAADnVQLp2VTi9JhtfkLOR9Y1ipNFObOGH9DQe5zbKxz77juhqA@mail.gmail.com>
Em Wed, Nov 27, 2019 at 08:37:59AM -0800, Alexei Starovoitov escreveu:
> On Wed, Nov 27, 2019 at 1:48 AM Jiri Olsa <jolsa@kernel.org> wrote:
> > adding support to link bpftool with libbpf dynamically,
> > and config change for perf.
> > It's now possible to use:
> > $ make -C tools/bpf/bpftool/ LIBBPF_DYNAMIC=1
> > which will detect libbpf devel package with needed version,
> > and if found, link it with bpftool.
> > It's possible to use arbitrary installed libbpf:
> > $ make -C tools/bpf/bpftool/ LIBBPF_DYNAMIC=1 LIBBPF_DIR=/tmp/libbpf/
> > I based this change on top of Arnaldo's perf/core, because
> > it contains libbpf feature detection code as dependency.
> > It's now also synced with latest bpf-next, so Toke's change
> > applies correctly.
> I don't like it.
> Especially Toke's patch to expose netlink as public and stable libbpf api.
> bpftools needs to stay tightly coupled with libbpf (and statically
> linked for that reason).
> Otherwise libbpf will grow a ton of public api that would have to be stable
> and will quickly become a burden.
I can relate to that, tools/lib/perf/ is only now getting put in place
because of these fears, hopefully the evsel/evlist/cpumap/etc
abstractions there have been in use for a long time and will be not be a
burden... :-)
- Arnaldo
next prev parent reply other threads:[~2019-11-27 18:44 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 9:48 [PATCH 0/3] perf/bpftool: Allow to link libbpf dynamically Jiri Olsa
2019-11-27 9:48 ` [PATCH 1/3] perf tools: Allow to specify libbpf install directory Jiri Olsa
2019-11-27 9:48 ` [PATCH 2/3] libbpf: Export netlink functions used by bpftool Jiri Olsa
2019-11-27 9:48 ` [PATCH 3/3] bpftool: Allow to link libbpf dynamically Jiri Olsa
2019-11-27 13:38 ` Quentin Monnet
2019-11-27 14:15 ` Jiri Olsa
2019-11-27 14:24 ` Arnaldo Carvalho de Melo
2019-11-27 14:31 ` Quentin Monnet
2019-11-27 15:48 ` Arnaldo Carvalho de Melo
2019-11-27 15:52 ` Quentin Monnet
2019-11-27 15:59 ` Arnaldo Carvalho de Melo
2019-11-27 14:29 ` Quentin Monnet
2019-11-27 16:41 ` Alexei Starovoitov
2019-11-27 16:37 ` [PATCH 0/3] perf/bpftool: " Alexei Starovoitov
2019-11-27 18:44 ` Arnaldo Carvalho de Melo [this message]
2019-11-27 20:24 ` Andrii Nakryiko
2019-11-27 21:22 ` Daniel Borkmann
2019-11-27 22:47 ` Jiri Olsa
2019-11-28 9:06 ` Toke Høiland-Jørgensen
2019-11-28 14:53 ` [PATCH bpf v2] bpftool: " Toke Høiland-Jørgensen
2019-11-28 15:32 ` Quentin Monnet
2019-11-28 15:52 ` Toke Høiland-Jørgensen
2019-11-28 16:07 ` [PATCH bpf v3] " Toke Høiland-Jørgensen
2019-11-28 17:30 ` Quentin Monnet
2019-11-29 8:12 ` Jiri Olsa
2019-11-29 8:24 ` Toke Høiland-Jørgensen
2019-11-29 10:24 ` Daniel Borkmann
2019-11-29 14:00 ` Toke Høiland-Jørgensen
2019-11-29 23:56 ` Daniel Borkmann
2019-12-02 8:59 ` Jiri Olsa
2019-12-02 17:09 ` [PATCH 0/3] perf/bpftool: " Andrii Nakryiko
2019-12-02 18:08 ` Toke Høiland-Jørgensen
2019-12-02 18:42 ` Andrii Nakryiko
2019-12-02 18:54 ` Arnaldo Carvalho de Melo
2019-12-02 19:21 ` Jiri Olsa
2019-12-02 19:54 ` Andrii Nakryiko
2019-12-02 20:02 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191127184400.GA4063@kernel.org \
--to=arnaldo.melo@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andriin@fb.com \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=jolsa@kernel.org \
--cc=kafai@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mpetlan@redhat.com \
--cc=namhyung@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=toke@redhat.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).