From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBCD0C432C0 for ; Wed, 27 Nov 2019 20:46:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B2A42217AB for ; Wed, 27 Nov 2019 20:46:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574887593; bh=FknDXqjToftO/T1ZTrO4rNNhR0VU4cU3YPNxDSoszY0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=jj1En6KmNUozT01rjupcuWM9ivlZK5WzfOjBvU4F7DZz7TR9HETvvL6GgKiuG5O4w EZlO+arOsXpngEo/crOWEJbjjRIDlbBpTBBBkHuIlBkDDX/8MjRLB0VZlDSDgfkwkk bcDo/fPyyU7xmyKYgJQRy53kLJP+QSkqur5PMTxg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728665AbfK0Uqc (ORCPT ); Wed, 27 Nov 2019 15:46:32 -0500 Received: from mail.kernel.org ([198.145.29.99]:58422 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729876AbfK0Uq3 (ORCPT ); Wed, 27 Nov 2019 15:46:29 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D55ED2158A; Wed, 27 Nov 2019 20:46:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574887588; bh=FknDXqjToftO/T1ZTrO4rNNhR0VU4cU3YPNxDSoszY0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KBczJEdxH+mCh+TuKeMD24AJ7Ny9Sj9hXZd65PP3moYy+klkapS6UR7ENXDp7cBrv Q2G9hfxJRmg2dawUG0hlZjncJJ1GSxwZOr7vm72Wb+KZAdm1pSAnO+3N3XAfbf033f j6KziNynYqkYtmildzP1tJqvduHZp9yr7BkHCQHk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Takashi Sakamoto , Takashi Iwai , Sasha Levin Subject: [PATCH 4.14 018/211] ALSA: isight: fix leak of reference to firewire unit in error path of .probe callback Date: Wed, 27 Nov 2019 21:29:11 +0100 Message-Id: <20191127203052.656103970@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191127203049.431810767@linuxfoundation.org> References: <20191127203049.431810767@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Takashi Sakamoto [ Upstream commit 51e68fb0929c29e47e9074ca3e99ffd6021a1c5a ] In some error paths, reference count of firewire unit is not decreased. This commit fixes the bug. Fixes: 5b14ec25a79b('ALSA: firewire: release reference count of firewire unit in .remove callback of bus driver') Signed-off-by: Takashi Sakamoto Signed-off-by: Takashi Iwai Signed-off-by: Sasha Levin --- sound/firewire/isight.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sound/firewire/isight.c b/sound/firewire/isight.c index 5826aa8362f10..9edb26ab16e90 100644 --- a/sound/firewire/isight.c +++ b/sound/firewire/isight.c @@ -639,7 +639,7 @@ static int isight_probe(struct fw_unit *unit, if (!isight->audio_base) { dev_err(&unit->device, "audio unit base not found\n"); err = -ENXIO; - goto err_unit; + goto error; } fw_iso_resources_init(&isight->resources, unit); @@ -668,12 +668,12 @@ static int isight_probe(struct fw_unit *unit, dev_set_drvdata(&unit->device, isight); return 0; - -err_unit: - fw_unit_put(isight->unit); - mutex_destroy(&isight->mutex); error: snd_card_free(card); + + mutex_destroy(&isight->mutex); + fw_unit_put(isight->unit); + return err; } -- 2.20.1