From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CE4CC432C0 for ; Wed, 27 Nov 2019 20:47:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 098D1217D6 for ; Wed, 27 Nov 2019 20:47:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574887626; bh=E2ZUTU5HCdCqmIb+dDMKUbL0XKlBuy6jI6sjlPvGW1I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=FdcfE5w+2Yf7rJYbfW/JrwjJ0G0vT5URk9ijK7MFWvhXm4gUDshWhEG8mrJpTy9AJ A4R0qRuPvK4//NNDc5weXgkNEW8wgGLUIZMisl0r9jrH+NgilI3nR5In/120JRtbYH zy7CH00sRc3hOuXQPcpw1ROsn5qsdfQmuThhkFCQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729022AbfK0UrE (ORCPT ); Wed, 27 Nov 2019 15:47:04 -0500 Received: from mail.kernel.org ([198.145.29.99]:59478 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729952AbfK0UrA (ORCPT ); Wed, 27 Nov 2019 15:47:00 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 53989217D6; Wed, 27 Nov 2019 20:46:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574887619; bh=E2ZUTU5HCdCqmIb+dDMKUbL0XKlBuy6jI6sjlPvGW1I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=up6oTUEK4fgVmVqOBJTvsGgXH7PyS8L+RErqAKut5P71bablFH8eyBvVGwCLkEfBG YK1/TQKD2MpzYmLHOof27YGvREg6EyLyt6sPC0YN7kSNGUBUiX6a5T/tdLC4hCa91p LJgH6Q+1VGQ4qYMwEu5Osg1T/tzmV7H00MEloyk8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jens Axboe , Sasha Levin Subject: [PATCH 4.14 029/211] skd: fixup usage of legacy IO API Date: Wed, 27 Nov 2019 21:29:22 +0100 Message-Id: <20191127203054.105908708@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191127203049.431810767@linuxfoundation.org> References: <20191127203049.431810767@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jens Axboe [ Upstream commit 6d1f9dfde7343c4ebfb8f84dcb333af571bb3b22 ] We need to be using the mq variant of request requeue here. Fixes: ca33dd92968b ("skd: Convert to blk-mq") Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- drivers/block/skd_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c index 64d0fc17c1742..95649025cde77 100644 --- a/drivers/block/skd_main.c +++ b/drivers/block/skd_main.c @@ -1417,7 +1417,7 @@ static void skd_resolve_req_exception(struct skd_device *skdev, case SKD_CHECK_STATUS_BUSY_IMMINENT: skd_log_skreq(skdev, skreq, "retry(busy)"); - blk_requeue_request(skdev->queue, req); + blk_mq_requeue_request(req, true); dev_info(&skdev->pdev->dev, "drive BUSY imminent\n"); skdev->state = SKD_DRVR_STATE_BUSY_IMMINENT; skdev->timer_countdown = SKD_TIMER_MINUTES(20); @@ -1427,7 +1427,7 @@ static void skd_resolve_req_exception(struct skd_device *skdev, case SKD_CHECK_STATUS_REQUEUE_REQUEST: if ((unsigned long) ++req->special < SKD_MAX_RETRIES) { skd_log_skreq(skdev, skreq, "retry"); - blk_requeue_request(skdev->queue, req); + blk_mq_requeue_request(req, true); break; } /* fall through */ -- 2.20.1