From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58B55C43215 for ; Wed, 27 Nov 2019 21:37:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2606520869 for ; Wed, 27 Nov 2019 21:37:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574890642; bh=mFIBF4zkhKQuS/73jWsWHvsc1rz6ROijEQbrtvRlYf8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=MFQ8rcHM3u8hS/u3hh5jfOifmf4HItLnhk7qM54FfQJXhCAZTYiEJexkfqaBMgMOe lKQmNYb6jbcIeriUvVFZz8MCQfEqIFQ/wLrcTAbtKyYHC9mkcXHu/hK28jA77c2IWq n1L3pBPNvULFMeBci648xLR4x+99sS0MX0UcQobk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729964AbfK0UrL (ORCPT ); Wed, 27 Nov 2019 15:47:11 -0500 Received: from mail.kernel.org ([198.145.29.99]:59638 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729949AbfK0UrF (ORCPT ); Wed, 27 Nov 2019 15:47:05 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 47885217D6; Wed, 27 Nov 2019 20:47:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574887624; bh=mFIBF4zkhKQuS/73jWsWHvsc1rz6ROijEQbrtvRlYf8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rglH2SkpLZvO66NzcfbH8q8FsBG6VeUCwzlN09KcD+EjVspLWfK6X3gSncCKnA6xm fLXuYWvBMk1p/nLwGvDmN/XtfkTgMVlWj66/q+nwuSheyEhKp7RAbQSHQQKYbwpwHS LT+DNV+jwx+fYTkGpnUeWBsN25oDJ2iIqbuOnXjo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sergei Shtylyov , Mark Brown , Sasha Levin Subject: [PATCH 4.14 031/211] spi: sh-msiof: fix deferred probing Date: Wed, 27 Nov 2019 21:29:24 +0100 Message-Id: <20191127203054.676612454@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191127203049.431810767@linuxfoundation.org> References: <20191127203049.431810767@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sergei Shtylyov [ Upstream commit f34c6e6257aa477cdfe7e9bbbecd3c5648ecda69 ] Since commit 9ec36cafe43b ("of/irq: do irq resolution in platform_get_irq") platform_get_irq() can return -EPROBE_DEFER. However, the driver overrides an error returned by that function with -ENOENT which breaks the deferred probing. Propagate upstream an error code returned by platform_get_irq() and remove the bogus "platform" from the error message, while at it... Fixes: 9ec36cafe43b ("of/irq: do irq resolution in platform_get_irq") Signed-off-by: Sergei Shtylyov Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/spi/spi-sh-msiof.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-sh-msiof.c b/drivers/spi/spi-sh-msiof.c index db2a529accae8..a7bd3c92356be 100644 --- a/drivers/spi/spi-sh-msiof.c +++ b/drivers/spi/spi-sh-msiof.c @@ -1283,8 +1283,8 @@ static int sh_msiof_spi_probe(struct platform_device *pdev) i = platform_get_irq(pdev, 0); if (i < 0) { - dev_err(&pdev->dev, "cannot get platform IRQ\n"); - ret = -ENOENT; + dev_err(&pdev->dev, "cannot get IRQ\n"); + ret = i; goto err1; } -- 2.20.1