From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AFC3C432C0 for ; Wed, 27 Nov 2019 20:47:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6F6AD21823 for ; Wed, 27 Nov 2019 20:47:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574887639; bh=wk9K6+R12aMkBHHoJ+8wPEfa30a10Re55114L6oEtzQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=JrN2MC3Sqs386DhfF+OBNGHcPG7WMdh5AuV7rP2R1IorWWdISjXZpwhp//olkCySc ZfmgdSAZ7OJOUtNeuU7Y3hdmlqX+oaQvz4BQGBrXeZ1e69/NSoUrVCZEwCmJT3wYfn FbN8+24CwyYTbOAhhBu4gYJXv5urasiNYqgUCfR0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729984AbfK0UrR (ORCPT ); Wed, 27 Nov 2019 15:47:17 -0500 Received: from mail.kernel.org ([198.145.29.99]:59776 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729962AbfK0UrK (ORCPT ); Wed, 27 Nov 2019 15:47:10 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3C64E21823; Wed, 27 Nov 2019 20:47:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574887629; bh=wk9K6+R12aMkBHHoJ+8wPEfa30a10Re55114L6oEtzQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZFj6Z/ntpRxcbVO168zQcXC6xHZHn4x9c/v9KIXcyv4pvSc9x3Bc8By7GLHgXmFSF 09GiQVTQrrD4KWBJLv2+/CAkre2xLlfH5apPWQALO3GXwLpBILzcY/BWPrjjP529jm CeqNpR+XtmkzoNsHCTGYxS0qxqFONWd0LOpECKuU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Chaotian Jing , Ulf Hansson , Sasha Levin Subject: [PATCH 4.14 032/211] mmc: mediatek: fix cannot receive new request when msdc_cmd_is_ready fail Date: Wed, 27 Nov 2019 21:29:25 +0100 Message-Id: <20191127203054.894383566@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191127203049.431810767@linuxfoundation.org> References: <20191127203049.431810767@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chaotian Jing [ Upstream commit f38a9774ddde9d79b3487dd888edd8b8623552af ] when msdc_cmd_is_ready return fail, the req_timeout work has not been inited and cancel_delayed_work() will return false, then, the request return directly and never call mmc_request_done(). so need call mod_delayed_work() before msdc_cmd_is_ready() Signed-off-by: Chaotian Jing Signed-off-by: Ulf Hansson Signed-off-by: Sasha Levin --- drivers/mmc/host/mtk-sd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c index 267f7ab08420e..a2ac9938d9459 100644 --- a/drivers/mmc/host/mtk-sd.c +++ b/drivers/mmc/host/mtk-sd.c @@ -885,6 +885,7 @@ static void msdc_start_command(struct msdc_host *host, WARN_ON(host->cmd); host->cmd = cmd; + mod_delayed_work(system_wq, &host->req_timeout, DAT_TIMEOUT); if (!msdc_cmd_is_ready(host, mrq, cmd)) return; @@ -896,7 +897,6 @@ static void msdc_start_command(struct msdc_host *host, cmd->error = 0; rawcmd = msdc_cmd_prepare_raw_cmd(host, mrq, cmd); - mod_delayed_work(system_wq, &host->req_timeout, DAT_TIMEOUT); sdr_set_bits(host->base + MSDC_INTEN, cmd_ints_mask); writel(cmd->arg, host->base + SDC_ARG); -- 2.20.1