From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48346C432C0 for ; Wed, 27 Nov 2019 20:48:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 17B1821826 for ; Wed, 27 Nov 2019 20:48:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574887707; bh=pz831w1FYuAKytC2tJGnO7bVucvEVuEDHUgUhpkzv/Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=lSE0cA0+mgdq1Melf6xbf9fpZnummcloTYKLrCxOheWTuY5jMhBfL2SSI4j4tmAdK asJ3036ZwxJ0l27HHw6rZoNWGMWjGbvvMSOyB7J+06oJO7K/quhXRMF7PCqb/5ThhN hPgoHJiPgCwSTyfdrGbCNBEUpjxc4q5hLxxSJ+lM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730137AbfK0Us0 (ORCPT ); Wed, 27 Nov 2019 15:48:26 -0500 Received: from mail.kernel.org ([198.145.29.99]:33600 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730121AbfK0UsW (ORCPT ); Wed, 27 Nov 2019 15:48:22 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 755E221826; Wed, 27 Nov 2019 20:48:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574887701; bh=pz831w1FYuAKytC2tJGnO7bVucvEVuEDHUgUhpkzv/Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=0+Gr1CZ1S6MCIWT4gOOe467Jf5SrQpfDMS1ACR/IuPaqVbms4wChNXyQo/waErV+0 EKdflakHp9t37E6qGIuwTyij2OmVUrfFBUCVNuKpR0XWFf66AhSpxa6qx3VIj4iP9g zQE3Fr4vZkKDReMtaB8EsmnARMuFmI/ELE0+zgeY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Philipp Klocke , Takashi Iwai , Sasha Levin Subject: [PATCH 4.14 062/211] ALSA: i2c/cs8427: Fix int to char conversion Date: Wed, 27 Nov 2019 21:29:55 +0100 Message-Id: <20191127203059.828096114@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191127203049.431810767@linuxfoundation.org> References: <20191127203049.431810767@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Philipp Klocke [ Upstream commit eb7ebfa3c1989aa8e59d5e68ab3cddd7df1bfb27 ] Compiling with clang yields the following warning: sound/i2c/cs8427.c:140:31: warning: implicit conversion from 'int' to 'char' changes value from 160 to -96 [-Wconstant-conversion] data[0] = CS8427_REG_AUTOINC | CS8427_REG_CORU_DATABUF; ~ ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ Because CS8427_REG_AUTOINC is defined as 128, it is too big for a char field. So change data from char to unsigned char, that it can hold the value. This patch does not change the generated code. Signed-off-by: Philipp Klocke Signed-off-by: Takashi Iwai Signed-off-by: Sasha Levin --- sound/i2c/cs8427.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/i2c/cs8427.c b/sound/i2c/cs8427.c index 7e21621e492a4..7fd1b40008838 100644 --- a/sound/i2c/cs8427.c +++ b/sound/i2c/cs8427.c @@ -118,7 +118,7 @@ static int snd_cs8427_send_corudata(struct snd_i2c_device *device, struct cs8427 *chip = device->private_data; char *hw_data = udata ? chip->playback.hw_udata : chip->playback.hw_status; - char data[32]; + unsigned char data[32]; int err, idx; if (!memcmp(hw_data, ndata, count)) -- 2.20.1