From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48385C432C0 for ; Wed, 27 Nov 2019 20:54:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 20E462068E for ; Wed, 27 Nov 2019 20:54:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574888076; bh=JsTi2r+/k7qMbPALGZPGQQ2+Iqyk+L2Lyk3Wtag/Xjc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=jraJ8ZfVy2mruLIQlAMfkfnnn4UonQUURAVLQxvd60O3E+is0hOMr+kvwxpEvZ5r+ NdOLIhncrGlElmylyfLnutQsFGqd1QtPpdPhMyxtlwV9M94e6OY43YjzXnp4XK1y0X q7Ajsh/xGXX5kJYwk5rf6NPkYZYkjxOaRSkMetDU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730846AbfK0Uye (ORCPT ); Wed, 27 Nov 2019 15:54:34 -0500 Received: from mail.kernel.org ([198.145.29.99]:44490 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730841AbfK0Uya (ORCPT ); Wed, 27 Nov 2019 15:54:30 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AFE152068E; Wed, 27 Nov 2019 20:54:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574888070; bh=JsTi2r+/k7qMbPALGZPGQQ2+Iqyk+L2Lyk3Wtag/Xjc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=X/uX/r8OfA/0EuzddlVQEPDigFelPAZmDNHldlV+KU1po8zaC3/rB0DWlso0bajor 4LN8jbCp9/msDRMk4YrmyC7P9ynko+1aBdKfY4PISGt86/6k9IuNXboF2Sjxk93P/w 16/3UuZhfHPDhloZfPD98JK4TGLvHIhGDrBT2pF0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johan Hovold Subject: [PATCH 4.14 204/211] USB: serial: mos7840: fix remote wakeup Date: Wed, 27 Nov 2019 21:32:17 +0100 Message-Id: <20191127203112.824461570@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191127203049.431810767@linuxfoundation.org> References: <20191127203049.431810767@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johan Hovold commit 92fe35fb9c70a00d8fbbf5bd6172c921dd9c7815 upstream. The driver was setting the device remote-wakeup feature during probe in violation of the USB specification (which says it should only be set just prior to suspending the device). This could potentially waste power during suspend as well as lead to spurious wakeups. Note that USB core would clear the remote-wakeup feature at first resume. Fixes: 3f5429746d91 ("USB: Moschip 7840 USB-Serial Driver") Cc: stable # 2.6.19 Reviewed-by: Greg Kroah-Hartman Signed-off-by: Johan Hovold Signed-off-by: Greg Kroah-Hartman --- drivers/usb/serial/mos7840.c | 5 ----- 1 file changed, 5 deletions(-) --- a/drivers/usb/serial/mos7840.c +++ b/drivers/usb/serial/mos7840.c @@ -2338,11 +2338,6 @@ out: goto error; } else dev_dbg(&port->dev, "ZLP_REG5 Writing success status%d\n", status); - - /* setting configuration feature to one */ - usb_control_msg(serial->dev, usb_sndctrlpipe(serial->dev, 0), - 0x03, 0x00, 0x01, 0x00, NULL, 0x00, - MOS_WDR_TIMEOUT); } return 0; error: