From: David Miller <davem@davemloft.net>
To: Jason@zx2c4.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
gregkh@linuxfoundation.org, torvalds@linux-foundation.org,
herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org
Subject: Re: [PATCH v1] net: WireGuard secure network tunnel
Date: Thu, 28 Nov 2019 22:27:35 -0800 (PST) [thread overview]
Message-ID: <20191128.222735.1430087391284485253.davem@davemloft.net> (raw)
In-Reply-To: <20191129033205.GA67257@zx2c4.com>
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
Date: Fri, 29 Nov 2019 04:32:05 +0100
> I'm not a huge fan of doing manual skb surgery either. The annoying
> thing here is that skb_gso_segment returns a list of skbs that's
> terminated by the last one's next pointer being NULL. I assume it's this
> way so that the GSO code doesn't have to pass a head around.
Sorry, I missed that this was processing a GSO list which doesn't use
double linked list semantics.
So ignore my feedback on this one :-)
next prev parent reply other threads:[~2019-11-29 6:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 11:26 [PATCH v1] net: WireGuard secure network tunnel Jason A. Donenfeld
2019-11-28 21:30 ` David Miller
2019-11-29 3:32 ` Jason A. Donenfeld
2019-11-29 6:27 ` David Miller [this message]
2019-11-29 11:47 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191128.222735.1430087391284485253.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Jason@zx2c4.com \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).