From: Changbin Du <changbin.du@gmail.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: Changbin Du <changbin.du@gmail.com>, Jiri Olsa <jolsa@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 0/2] perf: add support for logging debug messages to file
Date: Thu, 28 Nov 2019 15:04:25 +0000 [thread overview]
Message-ID: <20191128150424.r6zvv3jwlegjkhcb@mail.google.com> (raw)
In-Reply-To: <87v9r6e6gw.fsf@linux.intel.com>
On Tue, Nov 26, 2019 at 12:19:11PM -0800, Andi Kleen wrote:
> Changbin Du <changbin.du@gmail.com> writes:
>
> > When in TUI mode, it is impossible to show all the debug messages to
> > console. This make it hard to debug perf issues using debug messages.
> > This patch adds support for logging debug messages to file to resolve
> > this problem.
>
> This was already solved in
>
> commit f78eaef0e0493f6068777a246b9c4d9d5cf2b7aa
> Author: Andi Kleen <ak@linux.intel.com>
> Date: Fri Nov 21 13:38:00 2014 -0800
>
> perf tools: Allow to force redirect pr_debug to stderr.
>
> When debugging the tui browser I find it useful to redirect the
> debug
> log into a file. Currently it's always forced to the message
> line.
>
> Add an option to force it to stderr. Then it can be easily
> redirected.
>
> You can do
>
> perf report --debug stderr 2> file ...
>
Yes, this is a good alternate approach with existing code. I still think
a new option 'file' is not bad. And later maybe we can ouput debug messages
to file only while errors ouput to both.
> -Andi
--
Cheers,
Changbin Du
prev parent reply other threads:[~2019-11-28 15:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 14:37 [PATCH v7 0/2] perf: add support for logging debug messages to file Changbin Du
2019-11-26 14:37 ` [PATCH v7 1/2] perf: support multiple debug options separated by ',' Changbin Du
2019-11-26 14:37 ` [PATCH v7 2/2] perf: add support for logging debug messages to file Changbin Du
2019-11-26 20:19 ` [PATCH v7 0/2] " Andi Kleen
2019-11-28 15:04 ` Changbin Du [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191128150424.r6zvv3jwlegjkhcb@mail.google.com \
--to=changbin.du@gmail.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).